Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Increase PHPStan to rule level to 1 (and beyond) #775

Closed
11 of 12 tasks
westonruter opened this issue Jul 10, 2023 · 3 comments
Closed
11 of 12 tasks

Increase PHPStan to rule level to 1 (and beyond) #775

westonruter opened this issue Jul 10, 2023 · 3 comments
Assignees
@westonruter
Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Milestone
performance-lab 3...

Comments

@westonruter
Copy link
Member

westonruter commented Jul 10, 2023 •
edited
Loading

Feature Description

#730 introduced PhpStan and started with level 0 conformance. Now we can increase the rule level to further improve the codebase.

Once this is resolved, another issue should be created to bump the rule level again.
@westonruter westonruter added [Type] Enhancement A suggestion for improvement of an existing feature Infrastructure Issues for the overall performance plugin infrastructure labels Jul 10, 2023
@westonruter westonruter mentioned this issue Jul 10, 2023
Merged
3 tasks
@westonruter westonruter changed the title Increase PHPStan to rule level to 1 Increase PHPStan to rule level to 1 (and beyond) Jul 10, 2023
@felixarntz felixarntz added the [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only label Jul 19, 2023
@westonruter westonruter mentioned this issue Jan 9, 2024
Merged
3 tasks
@westonruter westonruter added the Good First Issue Issue particularly suitable to be worked on by new contributors label Mar 7, 2024
@ValeriiVasyliev
Copy link
Contributor

On it

@westonruter westonruter mentioned this issue Mar 21, 2024
Merged
This was referenced Apr 11, 2024
Merged
Merged
@westonruter westonruter added this to the performance-lab 3.1.0 milestone Apr 12, 2024
@westonruter westonruter removed the Good First Issue Issue particularly suitable to be worked on by new contributors label Apr 15, 2024
@westonruter westonruter mentioned this issue Apr 18, 2024
Merged
This was referenced Apr 29, 2024
Merged
Merged
Merged
Merged
Merged
@westonruter
Copy link
Member Author

Over halfway to level 6 now!

@westonruter westonruter self-assigned this May 4, 2024
This was referenced May 4, 2024
Merged
Merged
Merged
Merged
Merged
Closed
Merged
Draft
@westonruter westonruter mentioned this issue May 13, 2024
Closed
@westonruter westonruter mentioned this issue May 13, 2024
Merged
@westonruter
Copy link
Member Author

I'm declaring this done! Level 8 seems to be sufficient. There is #1211 for updating to level 9, but as I mention in that PR, it seems of diminishing value.

This was referenced May 15, 2024
Merged
Merged
@westonruter westonruter added the skip changelog PRs that should not be mentioned in changelogs label May 17, 2024
@westonruter westonruter mentioned this issue May 23, 2024
Merged
13 tasks
@westonruter westonruter mentioned this issue Jun 6, 2024
Merged
This was referenced Jul 23, 2024
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@westonruter westonruter

Labels
Infrastructure Issues for the overall performance plugin infrastructure [Plugin] Performance Lab Issue relates to work in the Performance Lab Plugin only skip changelog PRs that should not be mentioned in changelogs [Type] Enhancement A suggestion for improvement of an existing feature
Projects
None yet
Milestone
performance-lab 3.1.0
Development

No branches or pull requests
3 participants
@westonruter @felixarntz @ValeriiVasyliev