From 1a08be5090c598310f5725a6cf6b4befed8a03c6 Mon Sep 17 00:00:00 2001
From: chiara aiola <aiola@netseven.it>
Date: Thu, 13 Jun 2024 14:21:40 +0200
Subject: [PATCH 1/2] DontExtractStandard.xml file creation

---
 WordPress/Docs/PHP/DontExtractStandard.xml | 33 ++++++++++++++++++++++
 1 file changed, 33 insertions(+)
 create mode 100644 WordPress/Docs/PHP/DontExtractStandard.xml

diff --git a/WordPress/Docs/PHP/DontExtractStandard.xml b/WordPress/Docs/PHP/DontExtractStandard.xml
new file mode 100644
index 0000000000..dc03e8ac42
--- /dev/null
+++ b/WordPress/Docs/PHP/DontExtractStandard.xml
@@ -0,0 +1,33 @@
+<?xml version="1.0"?>
+<documentation xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
+    xsi:noNamespaceSchemaLocation="https://phpcsstandards.github.io/PHPCSDevTools/phpcsdocs.xsd"
+    title="Don't exctract"
+    >
+    <standard>
+    <![CDATA[
+    Restricts the usage of `extract()` php function. It makes code harder to debug and harder to understand and may cause conflicts on variables names.
+    ]]>
+    </standard>
+    <code_comparison>
+        <code title="Valid: Similarly named functions or methods are fine">
+        <![CDATA[
+$var_array = array(
+    "title"    => "My title",
+    "content"  => "My content",
+    "ID"       => 123
+);
+my_extract( $var_array, EXTR_OVERWRITE );
+        ]]>
+        </code>
+        <code title="Invalid: ">
+        <![CDATA[
+$var_array = array(
+    "title"    => "My title",
+    "content"  => "My content",
+    "ID"       => 123
+);
+extract( $var_array, EXTR_OVERWRITE );
+        ]]>
+        </code>
+    </code_comparison>
+</documentation>

From c9c9d3d36862292bcd76897684bc60c3d82876e9 Mon Sep 17 00:00:00 2001
From: Chiara Aiola <aiola@netseven.it>
Date: Wed, 19 Jun 2024 15:47:45 +0200
Subject: [PATCH 2/2] Update DontExtractStandard.xml

fix incomplete description of invalid use case description
---
 WordPress/Docs/PHP/DontExtractStandard.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/WordPress/Docs/PHP/DontExtractStandard.xml b/WordPress/Docs/PHP/DontExtractStandard.xml
index dc03e8ac42..721cdaaa8a 100644
--- a/WordPress/Docs/PHP/DontExtractStandard.xml
+++ b/WordPress/Docs/PHP/DontExtractStandard.xml
@@ -19,7 +19,7 @@ $var_array = array(
 my_extract( $var_array, EXTR_OVERWRITE );
         ]]>
         </code>
-        <code title="Invalid: ">
+        <code title="Invalid: use `extract()` function">
         <![CDATA[
 $var_array = array(
     "title"    => "My title",