Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[FEATURE] Adding automatic pull request building for testing #7

Open
XanatosX opened this issue Jun 2, 2020 · 2 comments
Open

[FEATURE] Adding automatic pull request building for testing #7

XanatosX opened this issue Jun 2, 2020 · 2 comments

Comments

@XanatosX
Copy link
Contributor

XanatosX commented Jun 2, 2020

What is requested

Maybe we should add a GitHub action to build the project on each pull request, this could help us to see if new request can be build in a generalized way.

This should be relative simple to implement. But in my humble opinion we should adjust or merge #5 first. After this we can add a build check for pull request.

This can be extended to create automatic releases (Drafts) with the ready to use build included in the future.

@WizzardMaker
Copy link
Owner

I don't like the idea of automatic releases when working with the main branch, as it often is hot code which is being actively worked on.

The automated build testing is a nice idea though

@XanatosX
Copy link
Contributor Author

XanatosX commented Jun 3, 2020

We could change the automatic build to tag base so whenever someone makes a tag the automatic build is triggerd or we could use a develop and master branch like the git flow is doing it. Combined with the tag based builds this should be pretty safe that no broken features are shipped

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants