From defac384a0b5feb0803ac81e885549966e389806 Mon Sep 17 00:00:00 2001 From: Kumachan <29433058+kumachan-mis@users.noreply.github.com> Date: Sat, 4 Mar 2023 14:23:23 +0900 Subject: [PATCH] fix: fix jquery error in firefox (#837) --- README.md | 10 ++++++---- src/finder/github/gitHubFileViewFinder.ts | 2 +- 2 files changed, 7 insertions(+), 5 deletions(-) diff --git a/README.md b/README.md index 205ec6cff..584bc0e1a 100644 --- a/README.md +++ b/README.md @@ -18,7 +18,8 @@ - File Viewer - https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/class.pu - - `!include` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/state.pu + - `!include` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/including.pu + - `!includesub` directive: https://github.com/WillBooster/plantuml-visualizer/blob/master/puml-sample/subincluding.pu - Issues: https://github.com/WillBooster/plantuml-visualizer/issues/54 - Pull Requests - Added: https://github.com/WillBooster/plantuml-visualizer/pull/49/files @@ -38,7 +39,8 @@ - GitHub Raw Files (only Chrome) - https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/class.pu - - `!include` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/state.pu + - `!include` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/including.pu + - `!includesub` directive: https://raw.githubusercontent.com/WillBooster/plantuml-visualizer/master/puml-sample/subincluding.pu - IMPORTANT NOTE: any extension on Firefox cannot work on GitHub Raw Files due to https://bugzilla.mozilla.org/show_bug.cgi?id=1411641 - Local Files - file:///C:/Users/XXX/Projects/plantuml-visualizer/puml-sample/class.pu @@ -62,9 +64,9 @@ The visualization result of https://github.com/WillBooster/plantuml-visualizer/p ## Default Visualization Server -The default server is https://willbooster-plantuml.herokuapp.com +The default server is https://plantuml-service-willbooster.fly.dev ([source code](https://github.com/WillBooster/plantuml-service)). -You may check the PlantUML version via [this link](https://willbooster-plantuml.herokuapp.com/version). +You may check the PlantUML version via [this link](https://plantuml-service-willbooster.fly.dev/version). You may use another **HTTPS** PlantUML server by changing settings in the configuration window. diff --git a/src/finder/github/gitHubFileViewFinder.ts b/src/finder/github/gitHubFileViewFinder.ts index 3fe0095a7..b69540865 100644 --- a/src/finder/github/gitHubFileViewFinder.ts +++ b/src/finder/github/gitHubFileViewFinder.ts @@ -19,7 +19,7 @@ export class GitHubFileViewFinder implements CodeFinder { const $text = $texts.eq(i); const $fileLines = $text.find('tr'); let fileText = [...Array.from({ length: $fileLines.length }).keys()] - .map((lineno) => $fileLines.eq(lineno).find("[id^='LC'").text() + '\n') + .map((lineno) => $fileLines.eq(lineno).find("[id^='LC']").text() + '\n') .join(''); fileText = await this.preprocessIncludeDirective(webPageUrl, fileText); fileText = await this.preprocessIncludeSubDirective(webPageUrl, fileText);