Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactoring - save directly in store #31

Open
Tronix117 opened this issue Sep 19, 2017 · 0 comments
Open

Refactoring - save directly in store #31

Tronix117 opened this issue Sep 19, 2017 · 0 comments

Comments

@Tronix117
Copy link
Collaborator

Instead of adding included to output object, so that JSData know where to dispatch them, it is safer and cleaner to only add foreignKeys links, and save all included objects directly in each corresponding stores.

It is subject to discussions, but it can further enhance stability, if any issue were to occur.

The drawback is that it needs to be saved in datastore, can't be bypass; however I don't see a use case where you need to fetch included data and don't want to be in datastore (except with raw). So if there is the option to not save in store, then included should be discarded.

This needs more thought and inputs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant