Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Impossible to claim rewards on first epoch if bonding occurs before epoch creation #258

Open
kerber0x opened this issue Jan 29, 2024 · 0 comments
Labels
bug Something isn't working

Comments

@kerber0x
Copy link
Contributor

If you want to report a security issue, please follow our security policy: https://github.com/White-Whale-Defi-Platform/migaloo-core/blob/main/SECURITY.md


Steps to Reproduce

  1. Execute X transaction on the vault contract
  2. ...
  3. ...

Expected results:

Actual results:

There's an edge case that prevents users from claiming rewards from the first epoch if they bond before said epoch is created.

This might have to do with how the weight is calculated.

How to reproduce:

  1. Deploy liquidity hub
  2. Bond assets to whale lair
  3. Set the genesis epoch to start in the future
  4. Create the first epoch when the time comes
  5. Try to claim with the account that bonded before

Expected:
Claim successful

Actual:
Can't claim


Additional context

Add any other context about the problem here, code snippets, json responses and so on.

Code sample
Logs
@kerber0x kerber0x added the bug Something isn't working label Jan 29, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

1 participant