Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Suggest moving away from npm blake3 package #7

Closed
jrayback opened this issue Nov 13, 2023 · 7 comments
Closed

Suggest moving away from npm blake3 package #7

jrayback opened this issue Nov 13, 2023 · 7 comments
Assignees

Comments

@jrayback
Copy link
Collaborator

The package has only 2,500 weekly downloads, and seems poorly maintained. An alternative to consider is @noble/hashes, which has 1.7 million weekly downloads, has a much better maintenance record, and is externally audited.

@AlexAndrei98
Copy link

Hey @jrayback I played a bit around with the nobles libraries and it looks like there is secp256r1 within @noble/curves

@AlexAndrei98
Copy link

I found this example of usage of secp256r1 in the did-jwt library here

@jrayback
Copy link
Collaborator Author

jrayback commented Dec 5, 2023

Oh, wow! Good catch! Thank you @AlexAndrei98 . I think the @noble library will be much better. I'll look at the example you sent through and include the migration to the new library in a PR resolving the other package dependency problems.

@jrayback jrayback assigned AlexAndrei98 and unassigned jrayback Dec 5, 2023
@jrayback
Copy link
Collaborator Author

jrayback commented Dec 5, 2023

@AlexAndrei98 , looks like you've already pushed a PR for this one. Thanks. I'll submit something today to handle the other package deps.

@AlexAndrei98
Copy link

@jrayback Thank you! Will try to fix the package-lock. I was looking at this while working on #15 .

@jrayback
Copy link
Collaborator Author

jrayback commented Dec 6, 2023

OK, @AlexAndrei98 , I'm actively working on handling the other packages:

  • text-encoding (remove)
  • urlsafe-base64 (remove in favor of native node.js capability)
  • ecdsa-secp256r1 (replace with @noble/curves)
    I hope to have a PR ready for review by tomorrow's dev meeting.

@jrayback
Copy link
Collaborator Author

jrayback commented Dec 8, 2023

closed by #16

@jrayback jrayback closed this as completed Dec 8, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants