-
Notifications
You must be signed in to change notification settings - Fork 24
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dialog closedby attribute and requestClose() function #329
Comments
Draft PR to give a rough idea of what this could look like whatwg/html#10157 |
It's rather unclear what the actual state of this proposal is. I take it whatwg/html#9373 (comment) is the current proposal still? I don't understand how people are now comfortable with changing the default. How does that reconcile with whatwg/html#9373 (comment)? And if |
To clarify the default will be the existing behaviour. No change will happen until you add the attribute with a specific value. In html terms the missing value state will be an "auto" state with no corresponding keyword. whatwg/html#10157 - here's a rought draft PR. I will take a look at the stacking stuff not familiar enough to answer. As for why to offer a way to disable it, well we need the mechanism to match existing behaviour for non-modal dialogs, and we may as well allow that for modal dialogs too? I believe Domenic may have mentioned that it's come up as a feature request too. |
To update this the latest PR is at whatwg/html#10737 |
Note there is an Intent to Ship on blink-dev https://groups.google.com/a/chromium.org/g/blink-dev/c/_pIOAyg1_E0/m/DnkvfQLVDgAJ for this feature - whatwg/html#10737 is landed as https://html.spec.whatwg.org/#attr-dialog-closedby. Now would be a good time to provide feedback (or a position one way or another), if any. cc @annevk |
While colleagues and I were not happy with how this landed in the HTML standard as discussed in whatwg/html#10906, the feature itself seems reasonable. As such, I suggest we resolve this as "position: support" one week from now. |
WebKittens
No response
Title of the spec
Dialog light dismiss
URL to the spec
https://html.spec.whatwg.org/multipage
URL to the spec's repository
No response
Issue Tracker URL
No response
Explainer URL
No response
TAG Design Review URL
No response
Mozilla standards-positions issue URL
mozilla/standards-positions#998
WebKit Bugzilla URL
No response
Radar URL
No response
Description
This is a request for a WebKit standards position on the idea of adding (optional) light dismiss functionality to Dialogs.
See whatwg/html#9373 for the discussion. The current proposal is a new attribute
closedby
(naming TBD) with three values allowing no close bahaviour, close watcher behaviour, or close watcher and light dismiss behaviour.The text was updated successfully, but these errors were encountered: