Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Throw error instead of warning on compression errors #52

Open
cgatian opened this issue Oct 18, 2016 · 1 comment
Open

Throw error instead of warning on compression errors #52

cgatian opened this issue Oct 18, 2016 · 1 comment

Comments

@cgatian
Copy link

cgatian commented Oct 18, 2016 •
edited
Loading

If a html template is unable to be compressed by the UglifyJsPlugin, this loader throws a warning, when it should throw an error.

By only throwing a warning the build succeeds even when --bail and the NoErrorsPlugin is configured. Ideally, if the html cannot be compressed an error should be thrown.

image

Any thoughts or ideas?
@WearyMonkey
Copy link
Owner

Looks like the error stack is originating from html-loader, not ngtemplate-loader.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@WearyMonkey @cgatian