Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PBCore Zipped nil:NilClass error still ingests asset #945

Open
ekemeyer opened this issue Jan 3, 2025 · 0 comments
Open

PBCore Zipped nil:NilClass error still ingests asset #945

ekemeyer opened this issue Jan 3, 2025 · 0 comments
Assignees
Labels

Comments

@ekemeyer
Copy link
Contributor

ekemeyer commented Jan 3, 2025

Describe the bug
When using PBCore Zipped ingest, xml from GBH throws the error
undefined method `first' for nil:NilClass

This error happens when children are missing a mediaType value. This is not required for PBCore and so it should accept the xml.

UPDATE: Discussed with Rebecca, Peter, etc. and it was decided that mediaType should remain required (especially if we're moving ahead with not requiring instantiationPhysical (format), so we still need to deal with the secondary issue...

A secondary issue is that instead of ignoring the xml ingest entirely, the asset is ingested and the children are ignored (physical instantiations, digital instantiations).

To Reproduce
See batch 3914 summary. See any of the 101 assets that failed due to undefined method `first' for nil:NilClass error. They were all partially ingested into AMS2.

Expected behavior
Appropriate and clear error is thrown and nothing gets ingested.

@ekemeyer ekemeyer self-assigned this Jan 7, 2025
@ekemeyer ekemeyer added the Bug label Jan 16, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant