Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BUG: Push#created_at being displayed as UTC time. #630

Open
afred opened this issue Oct 1, 2021 · 0 comments
Open

BUG: Push#created_at being displayed as UTC time. #630

afred opened this issue Oct 1, 2021 · 0 comments

Comments

@afred
Copy link
Contributor

afred commented Oct 1, 2021

The bug

  1. The date on the AMS production server defaults to UTC, and we don't change it when building stacks.
  2. That date is used for ActiveRecord timestamp fields automatically, e.g. Push models.
  3. The result is that UTC date/times are being stored in the DB.
  4. We are not adjusting the date time for display, so displayed times are UTC (but there's no indicator).

To reproduce

  1. Navigate to a Push (/pushes/[id]) where you already know about when it was created.
  2. Note that the displayed date/time is UTC, and not a local time.

Background

  1. I think storing the automatic ActiveRecord timestamps in UTC is a good idea, as it's agnostic of timezone.
  2. Converting to the correct timezone should be the priority.
  3. Defaulting to EST/EDT is fine for now, but...
  4. Ideally we should first try to get the users actual timezone, then default to EST/EDT. If that's not hard, go for it in this ticket. Otherwise, just add the default EST/EDT conversion.

Done when

Date/time for Pushes should at default to EST (or EDT if we are in daylight time).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant