From 165326e0182bab5296b6f2be7f90e0055371f2c0 Mon Sep 17 00:00:00 2001 From: "Caspian (Fedora Linux)" Date: Tue, 21 Jan 2025 13:33:25 -0500 Subject: [PATCH] First batch of removing old TODOs (I am a TODO hoarder, it seems) --- src/dashboard_defs/error.rs | 1 - src/spinitron/model.rs | 8 ++++---- src/texture.rs | 2 +- 3 files changed, 5 insertions(+), 6 deletions(-) diff --git a/src/dashboard_defs/error.rs b/src/dashboard_defs/error.rs index 1821682..e21d358 100644 --- a/src/dashboard_defs/error.rs +++ b/src/dashboard_defs/error.rs @@ -75,7 +75,6 @@ impl ErrorState { ////////// -// TODO: maybe replace this with the SDL message box? pub fn make_error_window(top_left: Vec2f, size: Vec2f, update_rate: UpdateRate, background_contents: WindowContents, text_color: ColorSDL) -> Window { diff --git a/src/spinitron/model.rs b/src/spinitron/model.rs index 39f0f2a..b32fd49 100644 --- a/src/spinitron/model.rs +++ b/src/spinitron/model.rs @@ -318,7 +318,7 @@ pub enum SpinitronModelName { // TODO: for any `String` field, if it equals the empty string, set it to `None` derive_spinitron_model_props!( -#[allow(dead_code)] // TODO: remove +#[allow(dead_code)] pub struct Spin { // This does not cover all the spin fields; this is just the most useful subset of them. @@ -349,7 +349,7 @@ pub struct Spin { }); derive_spinitron_model_props!( -#[allow(dead_code)] // TODO: remove +#[allow(dead_code)] pub struct Playlist { id: SpinitronModelId, persona_id: SpinitronModelId, // TODO: why are all the persona ids the same? @@ -374,7 +374,7 @@ pub struct Playlist { }); derive_spinitron_model_props!( -#[allow(dead_code)] // TODO: remove +#[allow(dead_code)] pub struct Persona { ////////// These are fields that are officially supported by Spinitron @@ -390,7 +390,7 @@ pub struct Persona { }); derive_spinitron_model_props!( -#[allow(dead_code)] // TODO: remove +#[allow(dead_code)] pub struct Show { id: SpinitronModelId, // Note: some shows will have the same IDS, but different times (e.g. WBOR's Commodore 64) diff --git a/src/texture.rs b/src/texture.rs index ac82f78..7d8cae1 100644 --- a/src/texture.rs +++ b/src/texture.rs @@ -130,7 +130,7 @@ pub type TextTextureScrollEaser = (fn(f64, bool) -> (f64, bool), f64); #[derive(Clone, Debug)] pub struct TextDisplayInfo<'a> { pub text: DisplayText<'a>, - pub color: ColorSDL, // TODO: change the name of this to `text_color`, perhaps + pub color: ColorSDL, pub pixel_area: (u32, u32), pub scroll_easer: TextTextureScrollEaser, pub scroll_speed_multiplier: f64