Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[feature suggestion] images to banner #15

Open
2old-4this opened this issue Jun 19, 2022 · 4 comments
Open

[feature suggestion] images to banner #15

2old-4this opened this issue Jun 19, 2022 · 4 comments

Comments

@2old-4this
Copy link

One more suggestion is the option to replace the banner solid colour with an image. If we can sort a .webm also is gonna be great.

The image could be a flavor image of the campaign the same for everyone, or separate for friends neutral and enemies, but it can go even further, by picking images for the biom of a monster or locations an NPC introduce him self- a Traven,a dark alley- on a sailing ship etc.

Another optional suggestion is for the image to be locked per scene for all actors

Or even more option for the image picking to work like the"Journal to canvas slideshow" module, that by clicking on an image from a journal, will be show on the banner.

@WBHarry
Copy link
Owner

WBHarry commented Jun 20, 2022

I like the idea of this as it definately adds a lot of potential flare to things 😄

I've been mulling over where to insert the option for a bit, and I think I'm going with the below idea:
image
I don't really want to break the neat one-line-per-setting, so I'm putting it as pair of small buttons to set background mode, to the left of the Background setting.
Toggling over to the lower button 'Background Image' will switch out the color input for a fileinput to get the image.

I'll be having a go at it and see how it ends up looking, and I'll be checking out 'Journal to canvas slideshow' and other options after the basics seem okay!

@2old-4this
Copy link
Author

That's awesome. man thanks so much for your effort.

me thinking: The only problem I can see coming up from using images with a different aspect ratio from that of the banner.

I mean, will the banner be replaced by the image? Or the image will be cropped inside the boundaries of the banner? And if so, how will it be aligned?
Untitled-20

@WBHarry
Copy link
Owner

WBHarry commented Jun 20, 2022

My original thought was that it would be either or. Either a color background, or an image background. Images can be stretched to fit, although it might of course distort smaller images.

A more complete, thorough solution could be this:

  • Both a background-color and an image can be selected. The image will have a toggle 'Stretch to Fullscreen'.
  • If stretch to fullscreen is selected, then the image will be stretched if neccesary to fill the background. (checking with the preview tool is a good idea to see that it doesn't look strange)
  • If stretch to fullscreen is not selected, then the image will keep it's original size. I'm thinking that handling this could be handled in a similar way to the banner positioning:
    image
    (Not the best example and just slapped together in paint, but you get the idea 😁)

Edit: I think a positioning tool for everything -on- the banner would actually make sense to incorporate into the 'Preview'. That way nothing new UI-wise has to be added. It could also be expanded to let the Avatar be moved around aswell possibly, if not in the same update, then as a logical next step. 😀

@2old-4this
Copy link
Author

That's awesome. For me it's easy to create a banner on the correct aspect ratio, crop them and use them as needed to bring a solid, nice looking, outcome.

But for the casual user, I'm afraid it's gonna be a hassle. Most of the images they'll be using are goggled, so “Stretch to Fullscreen” it's not gonna be optimal, as the banner of “introduce-me” it's very wide and limiting. A better option can be (if possible) to Fit-Horizontally and then the User repositions the image vertically to crop it where it's more pleasing to him.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants