This repository has been archived by the owner on Oct 15, 2024. It is now read-only.
Fonctions utilitaires en rapport avec les messages Discord #217
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Steellgold
commented
Jun 7, 2023
Steellgold
commented
- Close Fonction de récupération d'un message #211
feat(message.util.ts): add isDiscordLink function to check if a link is a valid discord link
…k function from message.util module
Bluzzi
suggested changes
Jun 7, 2023
Bluzzi
changed the title
…functions test(utils/message): add tests for isDiscordLink, getMessageContentFromLink and msgParams functions
|
|
…and remove getMessageContentFromLink function test(utils/message): add tests for containsDiscordLink function feat(utils/message): export containsDiscordLink function instead of isDiscordLink function
… for clarity and consistency with other functions
test(utils): add tests for extractDiscordLink function in extract-discord-link.test.ts
…port it to message.util.ts to avoid code duplication.
…e from a Discord message link test(utils): add test for getMessageFromLink function to check if it returns an instance of Message
…s and non-discord links
Steellgold
changed the title
Bluzzi
suggested changes
Jun 25, 2023
Comment on lines
25
to
27
| it("should return false because is litteraly not a discord link", () => { | ||
| expect(containsDiscordLink("Salut check la superbe vidéo: https://www.youtube.com/watch?v=dQw4w9WgXcQ")).toBe(false); | ||
| }); |
There was a problem hiding this comment.
Soit plus sérieux dans les titres
src/utils/message/message.util.ts
Outdated
Comment on lines
15
to
17
| export const containsDiscordLink = (content: string): boolean => { | ||
| return content.match(discordLinkRegex) !== null; | ||
| }; |
There was a problem hiding this comment.
Cette fonction est inutile. On peux s'en passer, juste la fonction extractDiscordLink() est suffisante, si elle retourne une array vide, ça veux dire qu'il n'y a pas de lien.
src/utils/message/message.util.ts
Outdated
Comment on lines
19
to
23
| export const extractDiscordLink = (content: string): string | string[] | null => { | ||
| const discordLinks = content.match(discordLinkRegex); | ||
| if (discordLinks) return discordLinks; | ||
| return null; | ||
| }; |
There was a problem hiding this comment.
Cette fonction devrait avoir cette valeur de retour :
type DiscordMessage = {
guildID: Snowflake;
channelID: Snowflake;
messageID: Snowflake;
}
export function extractDiscordLink = (messageContent: string): DiscordMessage[] => {
// TODO
}| return null; | ||
| }; | ||
|
|
||
| export const getMessageFromLink = async(link: string): Promise<Message<true> | null> => { |
There was a problem hiding this comment.
Suite aux modifications de extractDiscordLink, cette fonction devrait être bien plus simple car elle n'a plus à gérer la logique d'extraction.
Comment on lines
+26
to
+32
| const ids = [...link.match(/(\d+)/g) ?? []]; | ||
|
|
||
| if (ids.length !== 3) return null; | ||
|
|
||
| const guildId = ids[0]; | ||
| const channelId = ids[1]; | ||
| const messageId = ids[2]; |
There was a problem hiding this comment.
La manière de parse est pourrait être amélioré :
const content = `
Hello World!
https://canary.discord.com/channels/732251741999071303/786216771723198514/803532192793493544
are you ok ?
https://canary.discord.com/channels/732251741999071303/786216771723198514/803532192793493544
`;
const matchs = [...content.matchAll(/\/\d+\/\d+\/\d+/g)].map(element => {
const [guildID, channelID, messageID] = [...element[0].matchAll(/\d+/g)].map(e => e[0]);
return { guildID, channelID, messageID };
});
console.log(matchs);
Bluzzi
suggested changes
Jun 25, 2023
Comment on lines
7
to
8
| containsDiscordLink("Salut check : https://canary.discord.com/channels/732251741999071303/1113731433123565589/1113731587570413588") | ||
| ).toBe(true); |
…k examples chore(contains-discord-link.test.ts): remove unnecessary test case
…st.ts file chore(extract-discord-link.test.ts): update tests for extractDiscordLink function chore(index.ts): remove containsDiscordLink from export chore(message.type.ts): add DiscordMessage type chore(message.util.ts): update extractDiscordLink function to return DiscordMessage or empty array
… extractDiscordLink fix(resolve.cmd.ts): change type of extracted message from array to DiscordMessage | null fix(resolve.cmd.ts): change variable name from message to fetchedMessage
|
Que manque il a ce pr ? @Bluzzi |
|
Certainement la résolution des reviews ouvertes, bien que des nouveaux commits ont vu le jour depuis celle-ci. On a pas eu de nouvelle de Gaëtan et il n'a pas actualisé le status des reviews. |
Je n'avais pas répondu / resolve mais j'avais commit les changements. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.