Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug?] Maid with a torch vs Torch layer #51

Closed
Shionsan opened this issue Jul 3, 2016 · 4 comments
Closed

[Bug?] Maid with a torch vs Torch layer #51

Shionsan opened this issue Jul 3, 2016 · 4 comments

Comments

@Shionsan
Copy link

Shionsan commented Jul 3, 2016

Latest OptiFine now includes the Dynamic Lights mod feature. But with new class change trigger it bugs out the idea of [Escort maid] with a torch, as that maid instantly becomes a [Torch Layer]. And putting a torch in second slot automatically moves it into first. Is it possible to make only the first slot to be a trigger? Or at least to have torch layers to keep the last torch they have?

@Shionsan
Copy link
Author

Shionsan commented Jul 3, 2016

Seems the trigger only works when item is placed in the slot. Like with the archer - when bow is removed or gets broken - class stays unchanged, same with the [Torch Layer]. Btw, "placer" would be a better word, as "layer" has more of a "lay down on a bed" meaning.

Item removal should also become a trigger and switch maid into an escort class.

@Verclene
Copy link
Owner

Verclene commented Jul 4, 2016

Remove all torches and then put them on the offhand slot. Or nevertheless does maid keep being Torch"Placer"?

@Shionsan
Copy link
Author

Shionsan commented Jul 4, 2016

I've kept placing torch in main hand slot first. That triggered [Torch Placer] class change. Simply removing them doesn't change the class, so when I placed torches in offhand - they were moved back to first. Had to place some random item in the main slot to change it to [Escort class] first.

Complex trigger that would work on item removal or [on tool break] is in order (especially for battle classes). By complex I mean a check if maid has another item/tool/weapon to replace the broken/used one with before changing back into escort class.

And can you put current class name at some separate location of UI? That was mainly a reason I misunderstood this as a bug.

@Verclene
Copy link
Owner

Verclene commented Jul 4, 2016

And can you put current class name at some separate location of UI? That was mainly a reason I misunderstood this as a bug.

Well, mode string on GUI is often hidden. I'll improve it. Closing to be move to #57 .

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants