Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Comments on proposed APIs #44

Open
Govorunb opened this issue Jan 11, 2025 · 0 comments
Open

Comments on proposed APIs #44

Govorunb opened this issue Jan 11, 2025 · 0 comments
Assignees
Labels

Comments

@Govorunb
Copy link
Collaborator

Govorunb commented Jan 11, 2025

I was making my own backend for testing game integration using local models and noticed a couple small things I wanted to comment on/clarify:


First, shutdown/graceful - specifically the wants_shutdown boolean.

A lot of games can be saved and quit at any time. For them, the random boolean field is clunky and opaque. It can probably be split without any impact on the previous target use case:

{ "command": "shutdown/graceful/initiate" } | { "command": "shutdown/graceful/cancel" }

or

{ "command": "shutdown/graceful", "data": { "request": "initiate" | "cancel" } }

to keep the previous shape while still improving explicitness and clarity.


Next, actions/reregister_all - is there a reason for this round trip instead of the game automatically sending its actions on connect?

That's all, thanks. If/when my backend stops being embarrassingly bad I'll make a PR to list it here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants