Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ortho missing blast files did not throw error #76

Open
aurreco-uga opened this issue Dec 20, 2023 · 0 comments
Open

ortho missing blast files did not throw error #76

aurreco-uga opened this issue Dec 20, 2023 · 0 comments
Assignees

Comments

@aurreco-uga
Copy link
Member

aurreco-uga commented Dec 20, 2023

Screen Shot 2023-12-20 at 8 18 46 AM

a user complained but if we had had emailed an error we would have fixed it long ago (asume it has been an issue since we released nov 28).

ryan slacks in ui-infra:
Looks like the executable completes "successfully" (need to see if the process query checks return code), and then the text results are just what see.
I found where we set the return code. We could easily throw exception if != 0, but that might have undesirable effects. Need to look more if you want to do something else here.
We should try to define the behavior we want and then make sure it's doing what we want in WDK. Remember the issue where a plugin failed and then we cached 0 rows in the WDK cache as if it had succeeded with zero rows? I'm worried handling this non-zero return code as an exception might recause that issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants