Bump bob-the-bundler to latest version
#2481
Open
+312
−743
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🦋 Changeset detectedLatest commit: 001019f The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
raulfdm
commented
Dec 11, 2023
| import { InternalAppContext } from './application'; | ||
| import { ExecutionContextBuilder } from './context'; | ||
| import { Application } from './types'; | ||
| import { uniqueId } from '../shared/utils.js'; |
There was a problem hiding this comment.
all those extension changes was done via bob bootstrap
raulfdm
commented
Dec 11, 2023
| }, | ||
| "buildOptions": { | ||
| "copy": [ | ||
| "LICENSE.md", | ||
| "README.md" | ||
| ] | ||
| } | ||
| }, | ||
| "type": "module" |
There was a problem hiding this comment.
This is the main reason I've considered a major bump.
It might impact in some projects
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR updates
bob-the-bundlerto the latest version, including a few fixes for modern TS settings.Fixes #2480
The only changes I've made were:
bob bootstrapso it can fix the package.json and the importsI've considered it a breaking change because how it declares the package.json changed a lot.
Type of change
Please delete options that are not relevant.
Screenshots/Sandbox (if appropriate/relevant):
How Has This Been Tested?
To test if that would work as expected, I've published it to a local npm registry, installed the new versions, and everything seems to be working fine.
Test Environment:
graphql-modules:Checklist:
Further comments
If this is a relatively large or complex change, kick off the discussion by explaining why you chose the solution you did and what alternatives you considered, etc...