Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make UAAppReviewManager more inheritance friendly #13

Open
tonyxiao opened this issue Dec 11, 2013 · 2 comments
Open

Make UAAppReviewManager more inheritance friendly #13

tonyxiao opened this issue Dec 11, 2013 · 2 comments

Comments

@tonyxiao
Copy link

Use [self class] rather than UAAppReviewManager explicitly.

Also maybe separate the class convenience methods into a separate file for those who want it and expose the actual instance methods for subclasses to override.

@coneybeare
Copy link
Member

Good idea. Would you be willing to do the alterations to the class methods and submit a PR?

@coneybeare
Copy link
Member

For clarification, I don't want to expose the instance methods, but they can be added manually in a private header of the subclass for those who want to subclass it. I do like the idea of using [self class] instead of UAAppReviewManager though.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants