Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Module conflict - Better Rolls for 5e #32

Open
Melkorhero opened this issue Aug 23, 2022 · 4 comments
Open

Module conflict - Better Rolls for 5e #32

Melkorhero opened this issue Aug 23, 2022 · 4 comments
Labels
bug Something isn't working duplicate This issue or pull request already exists

Comments

@Melkorhero
Copy link

Melkorhero commented Aug 23, 2022

Whenever you roll a dice with Die Hard module + Better rolls for 5e, it only shows the damage, not the attack roll result.
Better Rolls for 5e is a requirement since it automatically rolls attack and damage which makes it 5-10x faster than without it. Sorta a requirement.

@Melkorhero Melkorhero changed the title Attack to hit doesn't show Module conflict - Better Rolls for 5e Aug 23, 2022
@UranusBytes UranusBytes added bug Something isn't working duplicate This issue or pull request already exists labels Aug 27, 2022
@UranusBytes
Copy link
Owner

Duplicate of #6

Still investigating options to make it work....

@UranusBytes
Copy link
Owner

@Melkorhero Can you please provide a screenshot or more details about how this isn't showing the attack roll. In my testing, it is still showing the attack roll.

image

Are there any errors in the browser console?

@victordiehl
Copy link

Same happens with me using MidiQoL. Unfortunately I don't know in which Midi function this occurs, but I just left the two modules turned on to check if this was really the source of the error.

  • No error or warning is generated.
  • Only the fudge message is displayed. But not the default result message.

image

@Melkorhero
Copy link
Author

Melkorhero commented Aug 30, 2022

Hello there Victordiehl,

Well this is how it happens to me with Better rolls for 5e

image

But when it,s turned off, it works fine.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working duplicate This issue or pull request already exists
Projects
None yet
Development

No branches or pull requests

3 participants