Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hardcoded/unnecessary sleeps in admin start/stop #52

Open
scop opened this issue Nov 14, 2024 · 1 comment
Open

Hardcoded/unnecessary sleeps in admin start/stop #52

scop opened this issue Nov 14, 2024 · 1 comment

Comments

@scop
Copy link
Member

scop commented Nov 14, 2024

sleep(45);
return isset($stop['response']['error']['error_message']) ? $stop['response']['error']['error_message'] : 'success';
}
}
public function start(){
$instanceId = $this->params['model']->serviceProperties->get('instanceId|instance Id');
$start = $this->manager->StartServer($instanceId);
sleep(45);

These hardcoded 45 second sleeps seem quite arbitrary. They are in a sense also somewhat odd, because the response is captured before the sleep and I don't think the response will change during the sleep, so feels as if they are unnecessary as well.

@thevilledev
Copy link

thevilledev commented Nov 15, 2024

Note, affects admin operations only.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants