Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Consider renaming the module, spelling dir in lowercase #45

Open
scop opened this issue Nov 13, 2024 · 2 comments
Open

Consider renaming the module, spelling dir in lowercase #45

scop opened this issue Nov 13, 2024 · 2 comments

Comments

@scop
Copy link
Member

scop commented Nov 13, 2024

For the same reasoning as in #30, consider renaming the module directory to just upcloud. In addition to the "VPS" consideration, all other directories in WHMCS modules/servers/ are spelled in all lowercase too.

Consider also removing Vps from filenames within the dir, and making corresponding adjustments wherever needed

  • ./upCloudVps.php
  • ./lib/upCloudVps.php
  • ./templates/assets/img/vps-details.png
@scop
Copy link
Member Author

scop commented Nov 18, 2024

The "upCloudVps" name has ended up in the databases of some existing setups, and changing it would require migrations. This is not deemed worth it, so we'll leave the name as is.

@adityawbwce
Copy link
Contributor

Based on @scop comment we can close this issue

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants