Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hostname/IP address in server settings make no difference #35

Open
scop opened this issue Nov 13, 2024 · 1 comment
Open

Hostname/IP address in server settings make no difference #35

scop opened this issue Nov 13, 2024 · 1 comment

Comments

@scop
Copy link
Member

scop commented Nov 13, 2024

$this->baseUrl = 'https://api.upcloud.com/1.3/';

The base URL is hardcoded, hostname/IP address configured in server settings do not make a difference.

@adityawbwce
Copy link
Contributor

For WHMCS-based servers, a hostname and IP address are required, but they aren't utilized within the module. Additionally, the base URL is hardcoded, which is a necessary configuration. How would you like to proceed? Should I construct the base URL dynamically based on the hostname, or would you prefer it to remain hardcoded?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants