Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

executeRequest decodes response JSON thrice #32

Open
scop opened this issue Nov 12, 2024 · 1 comment
Open

executeRequest decodes response JSON thrice #32

scop opened this issue Nov 12, 2024 · 1 comment

Comments

@scop
Copy link
Member

scop commented Nov 12, 2024

json_decode($response, true),
json_decode($response, true),
[]
);
return ['response_code' => $statusCode, 'response' => json_decode($response, true)];

executeRequest appears to decode the JSON response thrice; twice for logging, and once for the return value. Could refactor to make that happen only once.

@adityawbwce
Copy link
Contributor

This issue has been resolved and will be included in the next pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants