Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bizarre (and otherwise undocumented) User IP repository paths in make_shell.tcl #6

Open
esophagus-now opened this issue Jan 29, 2020 · 1 comment

Comments

@esophagus-now
Copy link
Collaborator

esophagus-now commented Jan 29, 2020

Check out these lines:
https://github.com/UofT-HPRC/galapagos/blob/master/shells/tclScripts/make_shell.tcl#L112-#L115

As far as I can tell, these are the only lines which will add IP repository paths to a Galapagos project. This means that the user has to put all their repositories in the $galapagos_dir/shells/userIP folder.

Assuming that this is correct, this fact should be made apparent in the Galapagos documentation.

By the way, the other two ip repo paths that this command tries to add are

$galapagos_dir/hlsBuild
$galapagos_dir/shells/shell_ips

The first one makes sense, but I don't think the second one is used anymore.

@esophagus-now
Copy link
Collaborator Author

esophagus-now commented Jan 29, 2020

Wait, I'm an idiot. I was looking for the shell_ips folder yesterday but for some reason I didn't notice it.

By the way, I realized last night that you said you were planning to fix up the logical file syntax. My original to just edit the documentation is kind of dumb; it would be better to allow the user to put some kind of <path> tags to indicate where the IP is situated.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant