Learning Insights Metrics Fix #683
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…use on facility and adding a sum() function
corypride
force-pushed
the
fix-learning-insights-metrics
branch
from
e02f2fc to
57865f7
Compare
PThorpe92
reviewed
Jan 24, 2025
backend/src/database/activity.go
Outdated
| @@ -180,16 +181,14 @@ func (db *DB) GetAdminDashboardInfo(facilityID uint) (models.AdminDashboardJoin, | |||
| } | |||
| func (db *DB) GetTotalCoursesOffered(facilityID *uint) (int, error) { | |||
There was a problem hiding this comment.
as discussed on slack.. since courses are not unique to a facility, should we remove the option to filter?
There was a problem hiding this comment.
Should i still log the FacilityID value here?
PThorpe92
reviewed
Jan 24, 2025
| Select("COUNT(DISTINCT ue.user_id) AS students_enrolled"). | ||
| Joins("INNER JOIN users u on ue.user_id = u.id") | ||
|
|
||
| Select(`COUNT(DISTINCT u.id) AS num_enrolled`). |
There was a problem hiding this comment.
This (and others I see) on the other hand, since we are filtering the students themselves by facility, or getting the amount of time from students in a facility, then that makes sense
PThorpe92
reviewed
Jan 24, 2025
PThorpe92
reviewed
Jan 24, 2025
corypride
force-pushed
the
fix-learning-insights-metrics
branch
from
f2d6a99 to
dfce654
Compare
corypride
force-pushed
the
fix-learning-insights-metrics
branch
from
16d7555 to
dfce654
Compare
PThorpe92
reviewed
Jan 31, 2025
| if err != nil { | ||
| log.add("facilityId", claims.FacilityID) | ||
| log.add("facility_id", claims.FacilityID) |
There was a problem hiding this comment.
can we just add the facility_id to the log once at the top, so we don't add it every time there's an error?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of the change
Address inconsistencies in calculations and formulas on the Learning Insights Dashboard
Screenshot(s)
refactorInsights.mp4
Additional context