diff --git a/frontend/package.json b/frontend/package.json index e3de68e65b5a..cc9dce3453a3 100644 --- a/frontend/package.json +++ b/frontend/package.json @@ -23,7 +23,7 @@ "test:snapshot": "NODE_OPTIONS=\"${NODE_OPTIONS:-0} --no-experimental-fetch\" yarn test -u", "test:watch": "NODE_OPTIONS=\"${NODE_OPTIONS:-0} --no-experimental-fetch\" vitest watch", "lint:material:icons": "./check-imports.rc", - "lint": "biome lint src --apply", + "lint": "biome lint src --write", "lint:check": "biome check src", "fmt": "biome format src --write", "fmt:check": "biome check src", diff --git a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx index 715eb0ef5402..efd2d8a473a3 100644 --- a/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx +++ b/frontend/src/component/feature/FeatureToggleList/FeatureToggleListTable.tsx @@ -1,13 +1,5 @@ import { useCallback, useEffect, useMemo, useState, type VFC } from 'react'; -import { - Box, - Button, - IconButton, - Link, - Tooltip, - useMediaQuery, - useTheme, -} from '@mui/material'; +import { Box, Link, useMediaQuery, useTheme } from '@mui/material'; import { Link as RouterLink } from 'react-router-dom'; import { createColumnHelper, useReactTable } from '@tanstack/react-table'; import { PaginatedTable, TablePlaceholder } from 'component/common/Table'; @@ -34,12 +26,9 @@ import { FeatureToggleFilters } from './FeatureToggleFilters/FeatureToggleFilter import { withTableState } from 'utils/withTableState'; import { FeatureTagCell } from 'component/common/Table/cells/FeatureTagCell/FeatureTagCell'; import { FeatureSegmentCell } from 'component/common/Table/cells/FeatureSegmentCell/FeatureSegmentCell'; -import { useUiFlag } from 'hooks/useUiFlag'; import { FeatureToggleListActions } from './FeatureToggleListActions/FeatureToggleListActions'; import useLoading from 'hooks/useLoading'; import { usePlausibleTracker } from 'hooks/usePlausibleTracker'; -import { useFeedback } from '../../feedbackNew/useFeedback'; -import ReviewsOutlined from '@mui/icons-material/ReviewsOutlined'; import { useGlobalFeatureSearch } from './useGlobalFeatureSearch'; export const featuresPlaceholder = Array(15).fill({ @@ -55,7 +44,6 @@ const feedbackCategory = 'search'; export const FeatureToggleListTable: VFC = () => { const theme = useTheme(); - const featureSearchFeedback = useUiFlag('featureSearchFeedback'); const { trackEvent } = usePlausibleTracker(); const { environments } = useEnvironments(); const enabledEnvironments = environments @@ -68,17 +56,6 @@ export const FeatureToggleListTable: VFC = () => { const { setToastApiError } = useToast(); const { uiConfig } = useUiConfig(); - const variant = - featureSearchFeedback !== false - ? (featureSearchFeedback?.name ?? '') - : ''; - - const { openFeedback } = useFeedback( - feedbackCategory, - 'automatic', - variant, - ); - const { features, total, @@ -269,15 +246,6 @@ export const FeatureToggleListTable: VFC = () => { return null; } - const createFeedbackContext = () => { - openFeedback({ - title: 'How easy was it to use search and filters?', - positiveLabel: 'What do you like most about search and filters?', - areasForImprovementsLabel: - 'What should be improved in search and filters page?', - }); - }; - return ( { setShowExportDialog(true)} /> - {featureSearchFeedback !== false && - featureSearchFeedback?.enabled && ( - <> - - - - - - } - /> - - } - onClick={ - createFeedbackContext - } - > - Provide feedback - - } - />{' '} - - } - onClick={ - createFeedbackContext - } - variant='outlined' - > - Provide feedback - - } - /> - - )} } > diff --git a/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap b/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap index 09b3a8f64a06..fcd678e3a5e8 100644 --- a/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap +++ b/frontend/src/component/menu/__tests__/__snapshots__/routes.test.tsx.snap @@ -270,14 +270,6 @@ exports[`returns all baseRoutes 1`] = ` "title": "Environments", "type": "protected", }, - { - "component": [Function], - "flag": "featureSearchFeedbackPosting", - "menu": {}, - "path": "/feedback", - "title": "Feedback", - "type": "protected", - }, { "component": [Function], "menu": {}, diff --git a/frontend/src/component/menu/routes.ts b/frontend/src/component/menu/routes.ts index eed9ef85c959..6942b5829c81 100644 --- a/frontend/src/component/menu/routes.ts +++ b/frontend/src/component/menu/routes.ts @@ -43,7 +43,6 @@ import { ViewIntegration } from 'component/integrations/ViewIntegration/ViewInte import { PaginatedApplicationList } from '../application/ApplicationList/PaginatedApplicationList'; import { AddonRedirect } from 'component/integrations/AddonRedirect/AddonRedirect'; import { Insights } from '../insights/Insights'; -import { FeedbackList } from '../feedbackNew/FeedbackList'; import { Application } from 'component/application/Application'; import { Signals } from 'component/signals/Signals'; import { LazyCreateProject } from '../project/Project/CreateProject/LazyCreateProject'; @@ -279,14 +278,6 @@ export const routes: IRoute[] = [ menu: { mobile: true, advanced: true }, enterprise: true, }, - { - path: '/feedback', - title: 'Feedback', - component: FeedbackList, - type: 'protected', - flag: 'featureSearchFeedbackPosting', - menu: {}, - }, // Tags { diff --git a/frontend/src/interfaces/uiConfig.ts b/frontend/src/interfaces/uiConfig.ts index e66fba2891ac..3f2d542a3664 100644 --- a/frontend/src/interfaces/uiConfig.ts +++ b/frontend/src/interfaces/uiConfig.ts @@ -71,12 +71,10 @@ export type UiFlags = { signals?: boolean; automatedActions?: boolean; celebrateUnleash?: boolean; - featureSearchFeedback?: Variant; enableLicense?: boolean; adminTokenKillSwitch?: boolean; feedbackComments?: Variant; showInactiveUsers?: boolean; - featureSearchFeedbackPosting?: boolean; userAccessUIEnabled?: boolean; outdatedSdksBanner?: boolean; estimateTrafficDataCost?: boolean; diff --git a/src/lib/types/experimental.ts b/src/lib/types/experimental.ts index 320efb6805d6..08715b299386 100644 --- a/src/lib/types/experimental.ts +++ b/src/lib/types/experimental.ts @@ -28,8 +28,6 @@ export type IFlagKey = | 'signals' | 'automatedActions' | 'celebrateUnleash' - | 'featureSearchFeedback' - | 'featureSearchFeedbackPosting' | 'extendedUsageMetrics' | 'adminTokenKillSwitch' | 'feedbackComments' @@ -44,7 +42,6 @@ export type IFlagKey = | 'outdatedSdksBanner' | 'responseTimeMetricsFix' | 'disableShowContextFieldSelectionValues' - | 'projectOverviewRefactorFeedback' | 'manyStrategiesPagination' | 'enableLegacyVariants' | 'extendedMetrics' @@ -147,23 +144,6 @@ const flags: IFlags = { process.env.UNLEASH_EXPERIMENTAL_CELEBRATE_UNLEASH, false, ), - featureSearchFeedback: { - name: 'withText', - enabled: parseEnvVarBoolean( - process.env.UNLEASH_EXPERIMENTAL_FEATURE_SEARCH_FEEDBACK, - false, - ), - payload: { - type: PayloadType.JSON, - value: - process.env - .UNLEASH_EXPERIMENTAL_FEATURE_SEARCH_FEEDBACK_PAYLOAD ?? '', - }, - }, - featureSearchFeedbackPosting: parseEnvVarBoolean( - process.env.UNLEASH_EXPERIMENTAL_FEATURE_SEARCH_FEEDBACK_POSTING, - false, - ), encryptEmails: parseEnvVarBoolean( process.env.UNLEASH_EXPERIMENTAL_ENCRYPT_EMAILS, false, @@ -234,10 +214,6 @@ const flags: IFlags = { .UNLEASH_EXPERIMENTAL_DISABLE_SHOW_CONTEXT_FIELD_SELECTION_VALUES, false, ), - projectOverviewRefactorFeedback: parseEnvVarBoolean( - process.env.UNLEASH_EXPERIMENTAL_PROJECT_OVERVIEW_REFACTOR_FEEDBACK, - false, - ), manyStrategiesPagination: parseEnvVarBoolean( process.env.UNLEASH_EXPERIMENTAL_MANY_STRATEGIES_PAGINATION, false, diff --git a/src/server-dev.ts b/src/server-dev.ts index 7f1ea4b8d418..b3b21d479943 100644 --- a/src/server-dev.ts +++ b/src/server-dev.ts @@ -41,11 +41,9 @@ process.nextTick(async () => { anonymiseEventLog: false, responseTimeWithAppNameKillSwitch: false, celebrateUnleash: true, - featureSearchFeedbackPosting: true, userAccessUIEnabled: true, outdatedSdksBanner: true, disableShowContextFieldSelectionValues: false, - projectOverviewRefactorFeedback: true, manyStrategiesPagination: true, enableLegacyVariants: false, extendedMetrics: true,