From 5af8d7602e654e9226c96a40e1db249082ce1384 Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Sun, 17 Dec 2023 01:25:40 +0100 Subject: [PATCH 1/9] fix: handle empty string in ChatSession.send_message --- google/generativeai/generative_models.py | 2 ++ 1 file changed, 2 insertions(+) diff --git a/google/generativeai/generative_models.py b/google/generativeai/generative_models.py index f1725815b..ab281cd7d 100644 --- a/google/generativeai/generative_models.py +++ b/google/generativeai/generative_models.py @@ -346,6 +346,8 @@ def send_message( stream: bool = False, **kwargs, ) -> generation_types.GenerateContentResponse: + if not contents: + raise TypeError("contents must not be empty") content = content_types.to_content(content) if not content.role: content.role = self._USER_ROLE From 37503ee33588d617b6543b0ce790583d28e8c9c0 Mon Sep 17 00:00:00 2001 From: Hamza-nabil Date: Mon, 18 Dec 2023 21:08:10 +0100 Subject: [PATCH 2/9] refactor: move empty string handling to content_types.to_content --- google/generativeai/generative_models.py | 2 -- google/generativeai/types/content_types.py | 3 +++ 2 files changed, 3 insertions(+), 2 deletions(-) diff --git a/google/generativeai/generative_models.py b/google/generativeai/generative_models.py index ab281cd7d..f1725815b 100644 --- a/google/generativeai/generative_models.py +++ b/google/generativeai/generative_models.py @@ -346,8 +346,6 @@ def send_message( stream: bool = False, **kwargs, ) -> generation_types.GenerateContentResponse: - if not contents: - raise TypeError("contents must not be empty") content = content_types.to_content(content) if not content.role: content.role = self._USER_ROLE diff --git a/google/generativeai/types/content_types.py b/google/generativeai/types/content_types.py index e6503ed63..75b2a9fad 100644 --- a/google/generativeai/types/content_types.py +++ b/google/generativeai/types/content_types.py @@ -189,6 +189,9 @@ def is_content_dict(d): def to_content(content: ContentType): + if not content: + raise TypeError("content must not be empty") + if isinstance(content, Mapping): content = _convert_dict(content) From e614ce0bc0048de4a178501a385caf88516540ec Mon Sep 17 00:00:00 2001 From: Mark Daoust Date: Tue, 19 Dec 2023 09:01:49 -0800 Subject: [PATCH 3/9] ValueError --- google/generativeai/types/content_types.py | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/google/generativeai/types/content_types.py b/google/generativeai/types/content_types.py index 75b2a9fad..ce7b3e59e 100644 --- a/google/generativeai/types/content_types.py +++ b/google/generativeai/types/content_types.py @@ -190,7 +190,7 @@ def is_content_dict(d): def to_content(content: ContentType): if not content: - raise TypeError("content must not be empty") + raise ValueError("content must not be empty") if isinstance(content, Mapping): content = _convert_dict(content) From 8ee2a7aebf3cb7d277682fc2bb1df00e4588151c Mon Sep 17 00:00:00 2001 From: Hamza-nabil Date: Thu, 10 Oct 2024 08:53:02 +0100 Subject: [PATCH 4/9] Add index for docs --- docs/index.md | 4 ++++ 1 file changed, 4 insertions(+) create mode 100644 docs/index.md diff --git a/docs/index.md b/docs/index.md new file mode 100644 index 000000000..298237680 --- /dev/null +++ b/docs/index.md @@ -0,0 +1,4 @@ +# Welcome to Google AI Python SDK Docs + +## API Reference +Check out the [API documentation](api/google/generativeai.md). \ No newline at end of file From e8c90299c68bfca51af6ffd50d3b9978f6deba0a Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Thu, 10 Oct 2024 08:58:06 +0100 Subject: [PATCH 5/9] Create CNAME --- docs/CNAME | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/CNAME diff --git a/docs/CNAME b/docs/CNAME new file mode 100644 index 000000000..946566431 --- /dev/null +++ b/docs/CNAME @@ -0,0 +1 @@ +test.py \ No newline at end of file From b14ecdab3107cdd04c33e893c10a3b43763a555e Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Thu, 10 Oct 2024 08:58:25 +0100 Subject: [PATCH 6/9] Delete CNAME --- docs/CNAME | 1 - 1 file changed, 1 deletion(-) delete mode 100644 docs/CNAME diff --git a/docs/CNAME b/docs/CNAME deleted file mode 100644 index 946566431..000000000 --- a/docs/CNAME +++ /dev/null @@ -1 +0,0 @@ -test.py \ No newline at end of file From 559512c58ea2a24120068f5f5888d02a147dea48 Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Thu, 10 Oct 2024 08:58:35 +0100 Subject: [PATCH 7/9] Create CNAME --- docs/CNAME | 1 + 1 file changed, 1 insertion(+) create mode 100644 docs/CNAME diff --git a/docs/CNAME b/docs/CNAME new file mode 100644 index 000000000..2c3184e9d --- /dev/null +++ b/docs/CNAME @@ -0,0 +1 @@ +google.genai.ma \ No newline at end of file From b191b4f9bd9c3f0c7009b859a909b8ce854566d6 Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Thu, 10 Oct 2024 08:59:13 +0100 Subject: [PATCH 8/9] Update CNAME --- docs/CNAME | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/docs/CNAME b/docs/CNAME index 2c3184e9d..5a9eb3e1b 100644 --- a/docs/CNAME +++ b/docs/CNAME @@ -1 +1 @@ -google.genai.ma \ No newline at end of file +google.genai.com \ No newline at end of file From bec03d5d8e1b9480acd48e81713e4736c0c7d757 Mon Sep 17 00:00:00 2001 From: Hamza NABIL <58815945+Hamza-nabil@users.noreply.github.com> Date: Thu, 10 Oct 2024 08:59:26 +0100 Subject: [PATCH 9/9] Delete CNAME --- docs/CNAME | 1 - 1 file changed, 1 deletion(-) delete mode 100644 docs/CNAME diff --git a/docs/CNAME b/docs/CNAME deleted file mode 100644 index 5a9eb3e1b..000000000 --- a/docs/CNAME +++ /dev/null @@ -1 +0,0 @@ -google.genai.com \ No newline at end of file