-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Display Info on LCD #18766
Comments
Thanks for the report. The proposed bug fix for the M118 without "Remaining Time" and with Search and Replace active as described will yield: See PR #18774 Here is "DisplayInfoOnLCD" with the proposed changes. |
Tried your modified file. Now M117 + M118 (+ M73) lines are inserted even without activating the "Display remaining time" :)
But in the past with old plugin "Display Progress On LCD" I was able only to insert M118. There was a dropdown menu (after activating "Time remaining" where I was able to choose the "Time Reporting Method" to select what should be inserted in the gcode. And if M118 was selected exactly the format I mentioned was inserted which is needed for a lot of people who are using artillery printers and the original tft. Also in the past I was able to insert seperate lines for time and percentage, which is now impossible.
Only if I set "LCD display option" to "Display Progress"... With "Filename and Layer" I get an "of" instead "/" which isn't easy to replace. Anyhow, I would need three seperate M118 lines for "time left", "data left" (percentage) and "layer left" |
Here is another try at it. I've added the "A1" and "P0" parameters for M118, made M117 optional, and there are some other changes. |
What is there works for most people and for Artillery printers. If you have a custom situation you can alter the script yourself or pay someone to do it. You could also bring the old script forward into the current version of Cura. |
But with your merged plugin "Display Info on LCD" it is now possible to insert M118 messages with layer change which wasn't the case before with plugin "Display Filename and Layer on LCD" ;)
Not with tft firmware provided by digant: https://www.thingiverse.com/thing:4294049 |
You have a 3rd party printer customized by a 4th party with 5th party firmware. There are bound to be issues. Since it would appear that all the lines would be the same you could do it with Insert At Layer Change? Insert at Layer Change does switch any line to upper case because many firmware flavors don't understand lower case commands. |
Cura Version
5.6.0 + Plugin"DisplayInfoOnLCD"
Operating System
Windows 11
Printer
Artillery Genius (NOT Pro)
Reproduction steps
Use latest cura release and a copy of new plugin "DisplayInfoOnLCD"
In the past there exist two seperate plugins DisplayProgressOnLCD.py + DisplayFilenameAndLayerOnLCD.py.
These are now combined in DisplayInfoOnLCD.py.
I found this pull request: #15866
Actual results
With shown settings I get something like:
a. M118 only icluded if "Display remaining time" is selected, it should be possible to include M118 messages also if "left time" information isn't used, so only "data left" information is needed. Maybe activate seperate checkboxes just like it is done with M73 line(s)
b. M117 messages are always included, it should be possible to insert ONLY M118
c. Percentage information not used in M118 statement ?! In shown example shouldn't it be M118 18/100 ? Not sure in this case because 15/83 = 18 percent...
d. "M118 A1 P0 ation:notification ... " missing. With old "Display Progress On LCD" I got this in the past wich is the format I need for my genius printer:
I get something like:
a. If "Text to display" is empty always the filename in inserted, which can be prevented by inserting a whitespace. This already was the case in old "Display Filename And Layer On LCD" plugin. Maybe use a checkbox if filename should be included and if unchecked don't write in in gcode.
b. M117 messages are always included, it should be possible to insert ONLY M118
c. "M118 A1 P0 ation:notification ... " missing. I would need something like this to update layer information on my Genius:
Expected results
See above
Add your .zip and screenshots here ⬇️
The text was updated successfully, but these errors were encountered: