Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374

theodorhansson · 2024-02-19T16:01:04Z

Description

This adds three printers that were previously missing from Cura.

ZYYX+
ZYYX Pro
ZYYX Pro ii

This also changes the manufacturer of the following printer. Which was previously made by Magicfirm Europe, but the firm was rebranded to ZYYX Labs AB.

ZYYX Agile

Type of change

Implements

Printer definition file(s)

How Has This Been Tested?

Testprints have been performed on all ZYYX printers except ZYYX Agile.

Test Configuration:

Windows
Linux (the profiles work but compiling to .x3g does not work on all machines)
MacOS

Checklist:

My code follows the style guidelines of this project as described in UltiMaker Meta and Cura QML best practices
I have read the Contribution guide
I have commented my code, particularly in hard-to-understand areas
I have uploaded any files required to test this change

theodorhansson · 2024-02-22T11:15:59Z

Note: this PR references some materials not yet implemented in Cura. These materials are currently awating approval in PR#281 in Ultimaker/fdm_materials.

theodorhansson · 2024-10-02T10:06:37Z

Or we could just leave it in 🤷

wawanbreton · 2024-10-02T10:45:47Z

Ok, looks like they just made a test with Cura, that ended up in the mainstream for weak reasons. I'm good with removing it then. If people somehow get to complain about this, they can still restore the files on their installation, and we shall put it back, but that is extremely unlikely.

github-actions · 2024-10-02T11:26:12Z

Error Files:

'File: resources/definitions/zyyx_agile.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'

wawanbreton

I spotted one issue with setting_version, and a possible optimization for variants. Otherwise looks very good !

resources/quality/zyyx_plus/ABS/zyyx_plus_abs_fast.inst.cfg

resources/variants/zyyx/zyyx_pro_carbon0.6.inst.cfg

theodorhansson · 2024-10-02T11:58:12Z

@wawanbreton Versions updated and line_width removed!

wawanbreton · 2024-10-02T12:08:21Z

Nice, thanks ! I just saw that some variants defined a line_width different from the machine_nozzle_size tough, those should probably be restored ?

Also there are some conflicts with main, because we just upgraded the settings_version to 24 (didn't think we would merge it that fast 😀) so you can ignore the conflicts and force your files removals.

theodorhansson · 2024-10-02T12:16:12Z

It appears I accidentally put weird values for line_width for the 0.8mm (and 0.2mm) nozzle. I believe the default should perform better.

Should I bump the settings version to 24?

wawanbreton · 2024-10-02T12:18:06Z

Should I bump the settings version to 24?

As you are on it, you can. Otherwise we plan to make an other pass for it.

theodorhansson · 2024-10-02T12:25:13Z

I have not checked v.24 compatibility, maybe I/we could do it in the future.

wawanbreton · 2024-10-02T12:28:05Z

changes between 23 and 24 are really self-contained and don't concern your settings at all, so you can safely put either 23 or 24

theodorhansson · 2024-10-02T12:39:34Z

Then 23 is ok by me.

wawanbreton · 2024-10-03T11:44:19Z

Hi @theodorhansson, can you just fix the git conflicts ? After that I guess we can merge this PR

# Conflicts: # resources/quality/zyyx/zyyx_agile_global_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_global_fine.inst.cfg # resources/quality/zyyx/zyyx_agile_global_normal.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_fine.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_flex_normal.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_pla_fast.inst.cfg # resources/quality/zyyx/zyyx_agile_pro_pla_fine.inst.cfg

github-actions · 2024-10-03T18:57:06Z

Error Files:

'File: resources/definitions/zyyx_agile.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'

theodorhansson · 2024-10-03T18:58:08Z

@wawanbreton I merged the branches (and updated to v24...).

wawanbreton · 2024-10-04T09:41:28Z

Very nice, thanks ! I can now approve and it will be merged after further testing.

github-actions · 2024-10-07T07:57:35Z

Error Files:

'File: resources/definitions/zyyx_agile.def.json must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_global_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_flex_normal.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fast.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'
'File: resources/quality/zyyx/zyyx_agile_pro_pla_fine.inst.cfg must not be deleted as it is not allowed. It will create issues upgrading Cura'

wawanbreton · 2024-11-18T14:23:04Z

Hi @theodorhansson, we just realized that the profiles contain a flow ratio of 420, which is totally outside usual specs. Is this on purpose, or possibly a mistake ?

theodorhansson · 2024-11-18T14:31:04Z

Hi @wawanbreton! It is on purpose. The extruder was changed by the manufacturer, but the firmware was not. I believe it was a geared Bondtech, but I'm not 100%. Unfortunately I have not personally printed with a ZYYX Pro II.

theodorhansson · 2024-11-18T14:34:21Z

I looked again at the Simplify3D profiles from the manufacturer and they also contain an abnormally large extrusion multiplier.

wawanbreton · 2024-11-18T15:05:19Z

Ok, thanks for your quick answer 🙂
We have decided to exclude this printer for the moment: the very high flow value may have side-effects on the slicing engine that nobody will see until they start a print. Since we are unable to confirm that this is not the case, we prefer not to risk it for now.
Maybe you can contact ZYYX and ask them for some testing, if they have an interest to it ?

theodorhansson added 27 commits January 25, 2024 15:43

Initial commit of zyyx profiles

f9836c0

Manufacturer name change

e7a54c5

Moved profiles to another folder

bfe4f31

moved zyyx profiles into subdirectories

f1f0f04

zyyx+ and agile quality now has subfolders

96e76ea

restricted Zyyx+ materials

9de9340

Added quality presets to zyyx+

66c6f59

removed generic pla from zyyx

6feeaf0

removed obsolete settings

81203b6

Removed settings that belong in print profiles

7a415d7

Allowed woodfill for ZYYX+

14909f4

Limited materials for ZYYX Pro

cca8671

Allowed generic materials for ZYYX+

ca5caef

Updated infill pattern for some ZYYX+ profiles

7c9d5d2

Added 1.2 profile to ZYYZ Pro

37398b2

Update ZYYX Pro startup routine

646870f

Updated ZYYX Pro profiles

4ca69d9

Fixed error in ZYYX Pro 1.2 nozzle

29e8fed

Updated ZYYX Pro start gcode

4d9f192

Updated ZYYX Pro profiles

63b71e6

added slight temp increase to zyyx carbon nozzle

fab683a

Revised ZYYX+ start code and dimensions

f6372eb

Updated ZYYX Pro startup code

8c69372

Updated zyyx pro variant

3439dde

removed zyyx+ and zyyx pro profiles

a10b431

fix comma in zyyx plus def

183f0b2

disallowed materials in zyyx pro

82e2108

github-actions bot added the PR: Community Contribution 👑 Community Contribution PR's label Feb 19, 2024

saumyaj3 added the PR: Printer Definitions 🏭 A PR that introduces or changes settings and printer definitions label Mar 1, 2024

Merge branch 'main' into zyyx_profile_addition

af467eb

wawanbreton requested changes Oct 2, 2024

View reviewed changes

resources/quality/zyyx_plus/ABS/zyyx_plus_abs_fast.inst.cfg Outdated Show resolved Hide resolved

resources/variants/zyyx/zyyx_pro_carbon0.6.inst.cfg Outdated Show resolved Hide resolved

theodorhansson and others added 2 commits October 2, 2024 13:54

update settings version, remove line width

4817d0a

Applied printer-linter format

4dd60bd

theodorhansson added 2 commits October 3, 2024 20:48

updated ZYYX settings version to 24

1a85b72

theodorhansson requested a review from wawanbreton October 3, 2024 18:58

wawanbreton approved these changes Oct 4, 2024

View reviewed changes

Merge branch 'main' into zyyx_profile_addition

449d816

HellAholic merged commit 11c7c9b into Ultimaker:main Oct 7, 2024
3 checks passed

wawanbreton mentioned this pull request Nov 18, 2024

CURA-12312 Remove ZYYX Pro II printer which remains untested #19922

Merged

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374

Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374

theodorhansson commented Feb 19, 2024 •

edited

Loading

theodorhansson commented Feb 22, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

wawanbreton left a comment

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

theodorhansson commented Oct 3, 2024

wawanbreton commented Oct 4, 2024

github-actions bot commented Oct 7, 2024

wawanbreton commented Nov 18, 2024

theodorhansson commented Nov 18, 2024

theodorhansson commented Nov 18, 2024

wawanbreton commented Nov 18, 2024

Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374

Add definitions and profiles to ZYYX+, ZYYX Pro and ZYYX Pro ii #18374

Conversation

theodorhansson commented Feb 19, 2024 • edited Loading

Description

Type of change

How Has This Been Tested?

Checklist:

theodorhansson commented Feb 22, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

github-actions bot commented Oct 2, 2024

wawanbreton left a comment

Choose a reason for hiding this comment

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 2, 2024

theodorhansson commented Oct 2, 2024

wawanbreton commented Oct 3, 2024

github-actions bot commented Oct 3, 2024

theodorhansson commented Oct 3, 2024

wawanbreton commented Oct 4, 2024

github-actions bot commented Oct 7, 2024

wawanbreton commented Nov 18, 2024

theodorhansson commented Nov 18, 2024

theodorhansson commented Nov 18, 2024

wawanbreton commented Nov 18, 2024

theodorhansson commented Feb 19, 2024 •

edited

Loading