-
-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Target machine name in line 2 of g-code prevents Ender-3 reading time/filament use/layer height #16938
Comments
Hey @Slashee-the-Cow, Welcome to the UltiMaker Cura Github 🚀 The Target Machine Name has been introduced here Ultimaker/CuraEngine#1871 I'll bring it up to the team to see what they can do to improve it. |
World's most simple post processor as a workaround: |
@smartin015 we've had this report with the Target Machine Name causing incorrect times/materials on the display. Do you need the comment to be this high? Could it be lower in the list of comments? @GregValiant, you have an Ender-3, right? Is it something you are seeing as well? |
Yes I do and no I'm not. I have the 8 bit board with the older 1.1.8 firmware. The machine name could be added to the end of the "generated with" line. It would be out of the way there. ;POSTPROCESED |
And here I thought a comment-only change would be safe :-\ it's unfortunate the firmware doesn't actually parse the headers to understand the values that it's reading. IMO this should be fixed on the reader side so it's more resilient to such changes. It'd be fine to move it down a ways, but I'd like folks to all agree on the notion that named comments in the sliced file should be strictly ordered like this. It seems quite brittle to make that assumption. |
Hi @Slashee-the-Cow, I made a quick fix to put the newly added comment at the end of the header. This will be added in 5.5 stable. However, this is not a healthy behavior and I would like to make sure the Ender firmware can handle such changes in the future. Could you give me your exact firmware version ? |
Sorry for the delayed response, got a lot of things on the boiler at the moment. Right now I'm running 1.0.4. 1.0.6 just came out and I'm debating installing it because 1.0.4 works :) |
The "machine_name" was moved to the end of data[0] in 5.5.0. That would seem to indicate it is no longer an issue. |
In the middle of a big print now but if you give me fifteen hours I can disable my post which removes that line and double check on my printer. |
Behaviour is fixed on my printer. |
From what I could see, the Marlin-based Creality firmwares should handle the header properly, whatever the order. However, for this printer the firmware seems to be different, and closed-source. So the only thing we could do is kindly ask them to make this piece of code a bit stronger, but I don't know how responsive they are to such requests. |
Can confirm that behaviour is unchanged in firmware version 1.0.6.
…On Mon, 30 Oct 2023 at 18:51, Erwan MATHIEU ***@***.***> wrote:
From what I could see, the Marlin-based Creality firmwares should handle
the header properly, whatever the order.
However, for this printer the firmware seems to be different, and
closed-source. So the only thing we could do is kindly ask them to make
this piece of code a bit stronger, but I don't know how responsive they are
to such requests.
—
Reply to this email directly, view it on GitHub
<#16938 (comment)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AFM7Y2FUS3IZMZ2RZELSHUTYB5MBJAVCNFSM6AAAAAA53YYKBOVHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTOOBUGY2TANZTHA>
.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Cura Version
5.5 Beta 1
Operating System
Windows 10 x64 22H2
Printer
Ender-3 / Ender-3 v2
Reproduction steps
Note: I usually use a custom profile I made for my Ender-3 V3 SE, but for this test I switched to the stock Ender-3 / Ender-3 v2 profile to be easily reproduced by other people. I've confirmed that the problem appears in the files for both my E3V3SE profile and the stock E3/E3v2 profile.
Slice a model (really, anything will do) in both 5.4 and 5.5 beta.
I used the project file included in the zip file (the fact that it's tiny doesn't matter, I tried more complex models and the same thing happened). Set it to the stock E3/E3v2 profile in Cura and standard quality preset.
I sliced it in both 5.4 and 5.5 beta 1 and saved separate g-code files.
Also I copied the file sliced in 5.5 beta and removed the second line (the comment starting in
;TARGET_MACHINE.NAME:
) manually.Actual results
Expected results
Estimated time, filament usage and layer height should be read correctly by printer regardless of Cura version used to slice model
Add your .zip and screenshots here ⬇️
e3 no info little disc.zip
The text was updated successfully, but these errors were encountered: