Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

RootRework: General Refactor and Rewrite #106

Open
3 tasks
MoffKalast opened this issue Mar 22, 2022 · 2 comments
Open
3 tasks

RootRework: General Refactor and Rewrite #106

MoffKalast opened this issue Mar 22, 2022 · 2 comments
Assignees

Comments

@MoffKalast
Copy link
Contributor

After #103 is done and we've got move_smooth to work on, we should do a general rewrite of the node to clean up the code and sort out or at least somewhat address the following issues and add required features:

  • reducing fishtailing
  • running away from/missing goals
  • implementing a 2D PID system
@dorkamotorka
Copy link
Contributor

Why do you want to implement 2D PID system? I assume it's lateral and linear control but that's already done. I forgot but I think we are using Stanley lateral controller and linear is just max acceleration->max speed-> max decceleration.

@MoffKalast
Copy link
Contributor Author

I'm not sure, I wasn't directly involved with that discussion at the time but that's what I last remember being the plan. We should probably have a meeting to get on the same page about it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

5 participants