Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

shuman old version in PHYEX repo, a cleaning possibility #56

Open
QuentinRodier opened this issue Oct 10, 2024 · 0 comments
Open

shuman old version in PHYEX repo, a cleaning possibility #56

QuentinRodier opened this issue Oct 10, 2024 · 0 comments
Labels
enhancement New feature or request

Comments

@QuentinRodier
Copy link
Collaborator

QuentinRodier commented Oct 10, 2024

This issue is not about shuman_phy.F90
shuman.f90 old version is present in :

  • common/aux for empty interfaces used by AROME and in OFFLINE
  • mesonh/aux

It is still used by the horizontal part of turb on CPU without pyft for MesoNH and OFFLINE.
AROME does not use turb_hor.
MesonH and OFFLINE : on GPU, pyft is applied with --shumanFUNCtoCALL which transform all shuman functions to shuman_phy routines.

If in MesoNH and PHYEX OFFLINE on CPU we can use --shumanFUNCtoCALL, we could remove shuman.f90 from the PHYEX repo.
(or even better but with much more work: keep only the shuman-fonction version and convert it to routines with pyft)

@QuentinRodier QuentinRodier added the enhancement New feature or request label Oct 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

1 participant