Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add the call to sources_neg_correct in AROME #51

Open
QuentinRodier opened this issue Jun 27, 2024 · 0 comments
Open

Add the call to sources_neg_correct in AROME #51

QuentinRodier opened this issue Jun 27, 2024 · 0 comments
Labels
enhancement New feature or request science Scientific issue

Comments

@QuentinRodier
Copy link
Collaborator

In AROME and co, in turb.f90 the correction of negativities values are not called (an empty routine is present in src/common).
The true routine is in src/mesonh/aux.

Adding this will change the results, it must be tested correctly.

Meanwhile, for GPU porting with OpenACC within routines, as sources_neg_corecct is directly moved out of PHYEX in the integration of MesoNH (because it is called in other parts of MesoNH), the routine is ported with hard-coded (not with pyft usage) MNH_MEM_GET, MPPDB_CHECKED and so on to ease the porting of sources_neg_correct in the GPU branch of MesoNH (arrays are declared in array-syntax style for ex).

@QuentinRodier QuentinRodier added enhancement New feature or request science Scientific issue labels Jun 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request science Scientific issue
Projects
None yet
Development

No branches or pull requests

1 participant