Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Primo Studio Support? #13

Open
gpeterso opened this issue Nov 5, 2020 · 0 comments
Open

Add Primo Studio Support? #13

gpeterso opened this issue Nov 5, 2020 · 0 comments

Comments

@gpeterso
Copy link
Member

gpeterso commented Nov 5, 2020

The Primo Studio version of this plugin is based on a very outdated fork of this repo. It does not work with Primo VE at all, and as far as I can tell, it has been abandoned. Oddly, the plugin metadata points to this repository and not the forked repo.

It should be possible to modify this plugin to work both with and without Primo Studio by checking the $injector service for an instance of primoExploreHathiTrustAvailabilityStudioConfig and then overriding the component bindings as needed.

This has been lingering as a low-priority item on my to-do list for a while because I don't use Primo Studio and haven't had a compelling reason to start. If you'd like to see the Primo Studio support for this plugin, please let me know by adding a +1 or comment to this issue. Or better yet, if you're a Primo Studio plugin wiz, feel free to submit a pull request 🙂 .

@gpeterso gpeterso changed the title Add Primo Studio Support Add Primo Studio Support? Mar 9, 2021
gpeterso added a commit to gpeterso/primostudio that referenced this issue Nov 1, 2024
I suggest that we remove the HathiTrust option from Primo Studio. This package is based on an unmaintained private fork that does not work with VE. Given that most of the community is now on VE, the presence of this forked package seems to cause nothing but confusion. More info: UMNLibraries/primo-explore-hathitrust-availability#13.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant