Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Old scipy fails to build on new compilers thanks to -Werror, fix attached #1

Closed
msoos opened this issue Jul 7, 2022 · 1 comment
Closed

Comments

@msoos
Copy link

msoos commented Jul 7, 2022

As per meelgroup/unigen#9 (comment) scipy here is too old for new compilers, and -Werror ensures that the build fails. I could make it work like this:

diff --git a/pyproject.toml b/pyproject.toml
index 16d9108..88ceabb 100644
--- a/pyproject.toml
+++ b/pyproject.toml
@@ -2,27 +2,28 @@
 name = "citoolkit"
 version = "0.1.0"
 description = "A library containing tools to create and solve instances of the Control Improvisation problem and its extensions."
 authors = ["Eric Vin <[email protected]>", "Daniel J. Fremont <[email protected]>"]
 maintainers = ["Eric Vin <[email protected]>"]
 license = "MIT"
 
 [tool.poetry.dependencies]
-python = "^3.8"
+python = ">=3.10.5,<3.11"
 pytest = {version = "^6.2.4", optional = true}
 pytest-randomly = {version = "^3.8.0", optional = true}
 sphinx = {version = "^4.1.1", optional = true}
 sphinx-autodoc-typehints = {version = "^1.12.0", optional = true}
 sphinx-rtd-theme = {version = "^0.5.2", optional = true}
-cvxpy = "^1.1.14"
+cvxpy = "^1.2.1"
 pytest-repeat = "^0.9.1"
 matplotlib = "^3.4.3"
 pyeda = "^0.28.0"
-z3-solver = "^4.8.14"
+z3-solver = "^4.9.1"
+scipy = "^1.8.1"
 boolexpr = "^2.4"
 psutil = "^5.8.0"
 multiprocess = "^0.70.12"
 
 [tool.poetry.extras]
 dev = [
     "pytest",
     "pytest-randomly",

Well, at least make finishes now :) Some of the changes may not be needed, but the python and the scipy ones seem to be needed.

Mate

@Eric-Vin
Copy link
Collaborator

Eric-Vin commented Jul 8, 2022

Great, glad it works now! I didn't originally have scipy as a dependency so I'm not exactly sure why it wasn't working, but this new pyproject.toml works for me so I'll switch to it and do some more thorough dependency testing later. Thanks again!

@Eric-Vin Eric-Vin closed this as completed Jul 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants