Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Milestone 4 feedback #106

Open
ghost opened this issue Feb 16, 2021 · 0 comments
Open

Milestone 4 feedback #106

ghost opened this issue Feb 16, 2021 · 0 comments

Comments

@ghost
Copy link

ghost commented Feb 16, 2021

Hey Group 6

Congrats on finishing up your last milestone! You've made some great improvements to the layout and that new tab provides a lot more useful functionality! I think these two tabs together make your app an excellent tool for narrowing in on the wines one is really interested in while still providing a big picture summary. There are a few minor problems still:

  • the scatter plot marginals, while useful could be presented a bit better (e.g. tool tips for the counts would make it more clear what the size of the points are indicating)
  • the global tools are no longer truly global since the variety/state filters don't change your bar plots or the heatmap
  • layout on the data tab could be improved
  • filters aren't fully linked between tabs (unfortunately tough to implement with plotly limitations, as you mention)

All of that said, I don't think these issues seriously detract from your app and I think it would still be very useful for your target audience.

Great job and best of luck with the rest of your courses!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

0 participants