Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(filter): added radio buttons #383

Merged
merged 2 commits into from
Jun 27, 2023
Merged

fix(filter): added radio buttons #383

merged 2 commits into from
Jun 27, 2023

Conversation

shobhitexe
Copy link
Contributor

Description

Changed the filter buttons from checkbox to radio in order to get more relevant filters

Fixes #350

Type of change

bug fix

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)

How Has This Been Tested?

i run build and it gave successfuk build

image

Checklist:

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been merged and published in downstream modules

Screenshots

Before

image

After

image

@vercel
Copy link

vercel bot commented Jun 23, 2023

Someone is attempting to deploy a commit to a Personal Account owned by @UBA-GCOEN on Vercel.

@UBA-GCOEN first needs to authorize it.

@UBA-GCOEN
Copy link
Owner

Hello @shobhitexe!
Thank you for submitting this pull request Your pull request will be reviewed by maintainers shortly. Meanwhile make sure you have referenced the respected issue in this pr Your pr will not be merged if it does not have reference to respected issue
please read our Contributing Guidelines https://github.com/UBA-GCOEN/StichHub/blob/main/CONTRIBUTING.md And Code of Conduct https://github.com/UBA-GCOEN/StichHub/blob/main/CODE_OF_CONDUCT.md

Copy link
Collaborator

@Siddhant-Patil0203 Siddhant-Patil0203 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks Good
@shobhitexe good to go

@vercel
Copy link

vercel bot commented Jun 27, 2023

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
stichhub ❌ Failed (Inspect) Mar 19, 2024 3:25pm
stichhub-backend ❌ Failed (Inspect) Mar 19, 2024 3:25pm

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

BUG: wrongs filter method
3 participants