-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Icons names + Syntax #3
Comments
I agree with Viviana but propose the use of upper cases as it will be a nicer fall back in the casethe font is missing, specially considering the purpose of the icons. They are supposed to stand out. colonICON_NAMEcolon So can also be |
I would propose case insensitivity and the hyphen to make it as easy as possible for the teachers |
Sure, will add the code and update the repo today (together with other stuff). |
Regarding case insensivity, do you mean the same result for |
Excellent question...
|
Dear all, I would like to comment on the nature of the meaning of some of these icons in primary school context. Even though the suggested names seem like a good match from a representation point of view I believe we need to also supply option for the meaning for teachers and students. Maybe we need two or even three wording options to access some icons. Notes below cheeringMegaphone | 1F4E3 | 📣 | announcement battery | 1F50B | 🔋 | battery jigsawPuzzlePiece | 1F9E9 | 🧩 | puzzle checkmark | 2713 | ✓ | check-mark crossMark | 274C | ❌ | cross-mark reward | None | | accomplishment |
Multiple triggers is fine with me. CaSe InSenSitIvItY is FiNe WiTh Me ToO :) |
Will implement it once we have the final keywords then. |
I made some test and CaSe InSenSitIvItY breaks the builder: There's an overflow in GSUB with that long strings: |
whOEvEr TyPes LIkE thIS DoES noT DesERvEs iCoNs :) UPPER-CASE, lower-case or Title-case is more than enough |
With fontmake? I am surprised! :) I thought @behdad fixed it all. Please proceed as you say, I agree that as Jose says its more than enough, but I would like you to add Behdad to the repo and post the long string fea code so he can fix it. It should be possible. |
Added. |
Hi, see our keyword proposal for icons. Let us know what you think and if you agree we'll put the
|
Probably the reward could use the |
Updated on the table 👆 |
"dinosaur" already using U+1F996 |
@vv-monsalve Aboud Vertical Metrics, this should be reviewed with @josescaglione |
The vertical metrics can be adjusted according to the new position of diacritics. I basically changed the viet double accents and the ydotbelow. This should allow tightening vMetrics. I opened a separate issue for this |
The new Vmetrics values were alreay updated in the sources. |
The mention of VM here was a question for reviewing the current VM with the icons now included. I've added a comment in the separate issue for them. |
The unencoded icons are decomposed if deleting one of the letters. How to prevent that from happening? icon-decompose.mov |
This isn't surprising as that explodes exponentially. If case-insensitivity is desired I suggest achieving that by mapping upper-case and lower-case letters to the same glyph. |
To clarify. Icons are not weight sensitive and were tweaked to a stroke thickness that made sense according to their complexity. They are not to form an icon system but to work naturally in the context of lowercase setting. As a result alignment and relative size may vary from drawing to drawing, this is once again according to the complexity of the shapes. If any of these "breaks" the vMetrics we can review but so far we are happy with the design. |
Yes, this is something that was bound to happen. |
I don't understand this. Can you explain? |
Hey Behdad, hope you are well buddy. What Viv means is that when you type :sun_in_love: the CALT replaces the string with an icon, but of course that disappears if you delete a letter. Not sure this is a problem though |
Thank you. Likewise.
Right. I think that's expected as well. |
Hi @josescaglione, the revisions were suggested in the spirit of them working naturally in the context of lowercase settings actually. For the icons to run smoothly with the text line, having their own nature, but working more balanced in size, position, and color. When testing them in the above sample, some of them seem to be working great to achieve that goal (e.g. shooting star, cake, palette, thumbs-up, etc). However, others would require only minor adjustments in position (mostly suns and rounded shapes), weight (pencil), or size (check and cross marks, puzzle, homework, pencil?) to work more evenly. Regarding the weight, it also affects the goal of working naturally with lowercase, given when using thinner weights, as seen in the image above, the icons are heavier than the text. However, I'll leave it up to @davelab6 opinion. |
I will review them @vv-monsalve |
We will be uploading a new file @vv-monsalve |
Thanks @behdad for weighing in :) The glyphs are different for upper and lower case, though. Is there really no way to do this in OpenType with bicameral designs? |
Not without the said explosion. A ligature of length ten would need to be encoded as 2^10=1024 separate ones! I can think of much more complicated ways to do this more efficiently, but probably out of scope for this project. Here's one:
The above scheme is complicated and slow, and still might cause offset overflows. I don't suggest implementing it. |
I agree it's totally not worth. |
Seems like something for me to raise in the OT2 context :) harfbuzz/boring-expansion-spec#96 Thanks @casasin and @behdad :) Reassigning to @vv-monsalve to verify, I think this is all set |
Hi, the latest font in repo at commit Image in the background, current font in magenta |
Check this other idea which is not totally bad at all: |
Thanks @behdad for the suggestion. However, probably at this point, the team will continue using the feature as it was implemented. |
I love it and I am in favor, if it is fast to render, and fast for @casasin to implement :) |
yes, Azza did a very nice job |
Our subsetter removes encoded icons by default in text families and we're seeing tofu in sandbox. Working with Nate to update the subsetter definition for this family so that we don't strip the icons out. |
I created a spreadsheet for the icons with the information from the above table, including a column for the unicode block. Doing so, I noticed the |
We reviewed this today with José and agreed on using
|
Done in |
Thanks @casasin. I've pulled and tested it in InDesign and is working fine. |
Changed already in |
The last decision made on this subject was to rename the icons to emojis and to discard the The v1.002 fonts already include this change, and the #12 is updating the Readme with the defined codepoints. So, I'm closing this issue here. Please feel free to reopen it if you consider it should be kept open for any reason. |
calt
feature with syntax<container>'icon-name'</container>
e.g.:
[:puzzle:]
for "puzzle" iconProposal for names to make them easy to remember/use:
Icons list with current names and names suggestions
The text was updated successfully, but these errors were encountered: