venasaur issues

[Fabio1988]

3_f169_b1 defaults to 3_f169, instead of 3_b1

I think this might be for all special forms?! so if form isn't defined we should use at least bread_mode?! :)

[TurtIeSocks]

@Mygod you're being summoned to say "I told you so"

[Fabio1988]

This got now fixed in Nileplumb's UICON repositories... But not sure if we need to fix it in UICONS rule

How does it work for shiny? Same?

[TurtIeSocks]

Part of it is up to the icon repo maintainers to make sure they have the same file.

Mygod has told me that bread mode should come before form, so above this line:

uicons.js/src/uicons.ts

Line 407 in 190e1ef

for (let f = 0; f < formSuffixes.length; f += 1) {

instead of before the shiny loop.

I assume this would solve this issue, but at this point would require uicons itself to change the standard and then it would be yet another breaking change for this library, for very small benefit imo.

[Mygod]

[Mygod]

If we expect Dynamax to override mega then put it before temp evolution; after if the other way around.

[Fabio1988]

I think bread can just be moved outside without breaking anything right? :)

Like that we would match for 3_b1 if the icon with form 169 won't exist, right?
We won't need to change it to 3_b1_f169
Naming can stay, just the order of resolving needs to change? :)

[Mygod]

If you like things to be terribly inconsistent because of a past misjudged decision then sure.

[Fabio1988]

Created a PR for the UICONS repo, and opened the discussion there... I don't think this change would be really breaking anything. Only Nileplumb added forms for breadmode

[Fabio1988]

This can be fixed now... None of the icon creators ever created icons with form & bread combined, except NilePlumb... He is aware of the change

Merged: UIcons/UIcons#38

[Mygod]

Looks like the game actually just treats gigantamax as a form instead, exactly like mega or primal: https://github.com/RetroJohn86/PoGo-Unpacked-DL-Assets/blob/main/Sprite/pm3.fGIGANTAMAX.icon.png