Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

A Mobile and Generic Asset Exchange using Liquidity Pooling [intergroup communication] #6001

Closed
daandeheij opened this issue Feb 17, 2021 · 17 comments

Comments

@daandeheij
Copy link

daandeheij commented Feb 17, 2021

We (group 1) suggest to use this issue in order to facilitate communication and coordination between the two groups.

The separate issues for notes for each group are: #5988 and #5996.

@devos50 I do not seem to be able to assign the correct labels and assignees/participants to this issue. If you could do so, it would be appreciated :)

@thversfelt
Copy link

Group 2 e-mailed about their intent to look into multi-sig wallets and implementing basic transactions in the superapp.

@daandeheij
Copy link
Author

The past few days, we have been thinking about how each group can develop a distinct app/project. Some possibilities that we consider:

  • Developing two different implementations for the liquidity pool: e.g. one group uses multi-sig, the other group uses a token-based solution.
  • Develop a solution for two different asset pairs. E.g.: one group does BTC/ETH, another group does ETH/DOGE.

We are curious to hear about your ideas and thoughts! :D

@synctext
Copy link
Member

synctext commented Feb 22, 2021

Proposal for next week sprint:

  • One team does Multi-Sig wallet for 1 week (group 1)
  • Other team does GUI interface, first implemention, 1 week (group 2)

@kchong97
Copy link

@Group1 we are working on a basic GUI interface, for now the idea is to have a page simply for viewing your balance for all the wallets (within this project mainly bitcoins and euro tokens) and another page for exchanging your assets for another. For bitcoin we have used bitcoinj to create a wallet for the user. We are also looking into doing the same for euro tokens.

We are working in this fork

@thversfelt
Copy link

Possible UI idea:

Start screen:
image

Liquidity pool screen for traders/liquidity providers
image

@EmielBoss
Copy link

@Group2 Sounds good! Are you guys available tomorrow (Friday) at 10:00 to meet up and synchronize?

@kchong97
Copy link

@Group2 Sounds good! Are you guys available tomorrow (Friday) at 10:00 to meet up and synchronize?

Yes! I will send a mail with a link to a Zoom meeting for tomorrow.

@chrislemaire
Copy link

@kchong97 and @EmielBoss, notice that the group1/2 mentions are notifying random users, of which one seems to be unused and the second seems to be owned by some Chinese users. They both might not appreciate being tagged randomly in this issue :P

@vstam1
Copy link

vstam1 commented Mar 1, 2021

We have a first sketch of the personal wallet page and the liquidity pool page:

@thversfelt
Copy link

thversfelt commented Mar 3, 2021

We created BTC multi-sig functionality and created a small demo. Check it out here: #5988 (comment). We are working on a seperate branch and created a seperate debug fragment where we (group 1) can work on the without annoying you guys

@synctext
Copy link
Member

synctext commented Mar 8, 2021

https://hummingbot.io/ and https://margin.de/
Documenting related work for future reference (unknown if they have something somewhat operational).

@daandeheij
Copy link
Author

daandeheij commented Mar 17, 2021

@chrislemaire

Could you give me access to the fork of group 2? :D

@chrislemaire
Copy link

Hmmm I had already invited you but it seems you hadn't accepted it. I will try to resend it.

@daandeheij
Copy link
Author

My bad! I glanced over it. Thank you :D

@daandeheij
Copy link
Author

Meeting 23/03/2021

  • Group 1 can try to integrate BTC/ETH pair into liquidity pool coded by group 2
  • Group 1 can try to integrate multisignature BTC into group 2's BTC/eurotoken liquidity pool
  • Group 2 is working on multi-signature for eurotoken

@thversfelt
Copy link

BTC multi-sig implementation update (branch: https://github.com/chrislemaire/trustchain-superapp/tree/multi-sig-wallets-implementation):

  • Refactored our BTC multi-sig demo into a more Object-Oriented format
  • Refactored liquidity pool app code to make place for BTC multi-sig
  • Implemented BTC multi-sig wallet creation into the app
  • Implemented BTC multis-sig depositing, and withdrawing into the app

The implementation is made on top of what code group 2 has presented last week. This means it only has partial trustchain integration. It required quite some refactoring, so it will look a bit different than what was presented to us. I do think that in its current state, group 2 should be able to use the current BTC implementation, to be able to complete their BTC-EURotoken demo.

Meanwhile, group 1 (us), will create a seperate fragmant in which we will contain and implement our BTC-ETH demo. This should allow us to work more independently from now on. Of course, please communicate any questions regarding BTC multi-sig with us.

@xoriole
Copy link
Contributor

xoriole commented Jun 3, 2021

Tribler/trustchain-superapp#75 PR is merged, closing the issue

@xoriole xoriole closed this as completed Jun 3, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment