Schedule adherence report include vehicle id #16
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
TsimurSh
commented
May 18, 2024
TsimurSh
commented
- added vehicle id to schedule adherence report
- added parameter flexibility for date
TsimurSh
changed the title
vesavlad
reviewed
May 19, 2024
| @@ -217,10 +217,12 @@ public static String timeRangeClause( | |||
|
|
|||
| SimpleDateFormat currentFormat = new SimpleDateFormat("MM-dd-yyyy"); | |||
| SimpleDateFormat requiredFormat = new SimpleDateFormat("yyyy-MM-dd"); | |||
| if (beginDate.charAt(4) != '-') { // for two patterns MM-dd-yyyy & yyyy-MM-dd | |||
There was a problem hiding this comment.
please format properly, and more than this what happens in case of the date in is the 'yyyy-MM-dd' format? we still need to validate is a valid date (eg. I want to make sure I do not endup passing 2024-29-23' to db
There was a problem hiding this comment.
Ok. just pushed a solution
…ed_adh_report-include-vehicle_id
vesavlad
approved these changes
May 19, 2024
vesavlad
deleted the
goeuropa/features/sched_adh_report-include-vehicle_id
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.