Attribute has a Context member and Builder like the other structs, and add a bunch more getters/setters for Attribute and Schema #7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
changed the title
rroelke
force-pushed
the
rr/attribute-schema-getters
branch
2 times, most recently
from
237773f to
d9a2484
Compare
davisp
approved these changes
Mar 19, 2024
rroelke
force-pushed
the
rr/attribute-schema-getters
branch
from
d9a2484 to
a7f52be
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds a bunch more pretty-much-straightforward methods to the Attribute and Schema classes.
Along the way we also stylize the
Attributestruct in a manner similar toSchema,Domain, andDimension. We split off aBuilderclass for the setter methods to construct a newAttributeand add a&'ctx Contextmember to make all of the methods more convenient.This surely conflicts with #6 which we should merge first.