Fixup Dependencies #4
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
davisp
force-pushed
the
pd/fixup-dependencies
branch
from
7289461 to
aeac796
Compare
rroelke
approved these changes
Mar 18, 2024
While reading through changes the new dependencies for tempdir and lazy_static caught my eye. The first bit was that these should be marked as `dev-dependencies` so that we're not forcing them onto users of `tiledb-rs` that don't need them. I've also removed the lazy_static dependency for a couple reasons. First, tests sharing global state should be a last resort which caught my eye first. But then I also realized, there's actually a subtle test we can add here per test. If core ever creates a non-writable file that breaks directory removal, we wouldn't know which test it was using lazy_static (as the error would happen at process exit). Creating a TempDir per test means we'll automatically know which test caused the issue (if it ever even happens).
davisp
force-pushed
the
pd/fixup-dependencies
branch
from
aeac796 to
dc5c9b9
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Both tempdir and lazy_static should be in the
[dev-dependencies]section so that we're not forcing them on downstream users. Secondly I removed lazy_static in favor of creating a TempDir per test to avoid sharing global state in tests as well as error localization in the very unlikely situation core ever creates a non-writable file.