Add proptest strategies for generating Dimension, a bunch of Debug impls, and even some arrow stuff #15
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rroelke
commented
Mar 20, 2024
rroelke
commented
Mar 20, 2024
rroelke
commented
Mar 20, 2024
rroelke
commented
Mar 20, 2024
davisp
approved these changes
Mar 20, 2024
| @@ -0,0 +1,65 @@ | |||
| use tiledb::context::Context as TileDBContext; | |||
| use tiledb::Result as TileDBResult; | |||
There was a problem hiding this comment.
We should probably get a PR up so that all of our important things are importable wiht a statement like:
use tiledb::{TileDBArray, TileDBContext, TileDBQuery, TileDBResult};
| proptest!(|(attr in tiledb_test::attribute::arbitrary(&c))| { | ||
| if let Some(arrow_field) = arrow_field(&attr).expect("Error reading tiledb attribute") { | ||
| assert_eq!(attr.name()?, *arrow_field.name()); | ||
| assert!(crate::datatype::is_same_physical_type(&attr.datatype()?, arrow_field.data_type())); |
There was a problem hiding this comment.
Hurms. Still more wonky lack of indentation. Perhaps this is because of the enclosing macro? I've verified locally that this is what rustfmt gives.
There was a problem hiding this comment.
It definitely seems like rustfmt doesn't know what to do with macros
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is what fell out of me working on the Arrow schema conversion functions. I wanted to do PBT for them, but that means we have to have strategies to generate Schema, which requires Domain, which requires Dimension, and maybe more!
So this pull request ends up being mostly test stuff with a little bit of arrow.
A few notable things:
fn_typedwhich emulates the same function we have in C++LifetimeStrategystruct which works around usingfn_typedin a strategy and also having a non-static lifetime due to needing the&'ctx tiledb::context::ContextDebugimpls I added useserde_jsonto format their results