Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
While reading through changes the new dependencies for tempdir and lazy_static caught my eye. The first bit was that these should be marked as `dev-dependencies` so that we're not forcing them onto users of `tiledb-rs` that don't need them. I've also removed the lazy_static dependency for a couple reasons. First, tests sharing global state should be a last resort which caught my eye first. But then I also realized, there's actually a subtle test we can add here per test. If core ever creates a non-writable file that breaks directory removal, we wouldn't know which test it was using lazy_static (as the error would happen at process exit). Creating a TempDir per test means we'll automatically know which test caused the issue (if it ever even happens).
- Loading branch information