Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace depricated os.popen with subprocess in call_shell_wrapper #35

Open
joelferrier opened this issue Jun 27, 2017 · 1 comment
Open

Comments

@joelferrier
Copy link
Member

joelferrier commented Jun 27, 2017

profilers/utils.py contains an os.popen call which which was deprecated in python2.6.
We should consider replacing the os.popen call with the subprocess module down the line to support profiling python 3 runtimes.

This is not a requirement for the MVP but should be tracked for once the MVP is complete.

@andrewkrug
Copy link
Member

Feel free to submit a pull that makes it forward compatible. Still have to maintain 2.7 support in this case.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

2 participants