From 84a8762e022f718268b8e068c0282d69971de409 Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:11:45 +0100 Subject: [PATCH 1/7] Use Ubuntu 24.04 for CI Updates #580 --- .github/workflows/ci.yml | 6 +++--- .github/workflows/heph.yml | 6 +++--- .github/workflows/http.yml | 4 ++-- .github/workflows/inbox.yml | 6 +++--- .github/workflows/remote.yml | 4 ++-- .github/workflows/rt.yml | 4 ++-- 6 files changed, 15 insertions(+), 15 deletions(-) diff --git a/.github/workflows/ci.yml b/.github/workflows/ci.yml index c32c21ee..566d3bbf 100644 --- a/.github/workflows/ci.yml +++ b/.github/workflows/ci.yml @@ -11,7 +11,7 @@ env: RUST_BACKTRACE: full jobs: Clippy: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 2 steps: - uses: actions/checkout@v4 @@ -21,7 +21,7 @@ jobs: - name: Run Clippy run: make clippy_all Rustfmt: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 2 steps: - uses: actions/checkout@v4 @@ -31,7 +31,7 @@ jobs: - name: Check formatting run: cargo fmt --all -- --check Docs: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 2 steps: - uses: actions/checkout@v4 diff --git a/.github/workflows/heph.yml b/.github/workflows/heph.yml index 2e585ffb..9aceee26 100644 --- a/.github/workflows/heph.yml +++ b/.github/workflows/heph.yml @@ -23,7 +23,7 @@ env: RUST_BACKTRACE: full jobs: Test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. steps: @@ -32,7 +32,7 @@ jobs: with: working-directory: ./ Miri: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. steps: @@ -41,7 +41,7 @@ jobs: with: working-directory: ./ Sanitiser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. strategy: diff --git a/.github/workflows/http.yml b/.github/workflows/http.yml index 6b01bed0..7f957eac 100644 --- a/.github/workflows/http.yml +++ b/.github/workflows/http.yml @@ -17,7 +17,7 @@ env: RUST_BACKTRACE: full jobs: Test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. steps: @@ -26,7 +26,7 @@ jobs: with: working-directory: http Sanitiser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. strategy: diff --git a/.github/workflows/inbox.yml b/.github/workflows/inbox.yml index 87e24616..8d8d4b36 100644 --- a/.github/workflows/inbox.yml +++ b/.github/workflows/inbox.yml @@ -17,7 +17,7 @@ env: RUST_BACKTRACE: full jobs: Test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 # This often run too many iterations on CI, which is not a real error. continue-on-error: ${{ matrix.release == 'release' }} @@ -32,7 +32,7 @@ jobs: test-flags: ${{ matrix.release }} working-directory: inbox Miri: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 steps: - uses: actions/checkout@v4 @@ -40,7 +40,7 @@ jobs: with: working-directory: inbox Sanitiser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 strategy: fail-fast: false diff --git a/.github/workflows/remote.yml b/.github/workflows/remote.yml index 2cc1285c..ac12c8b0 100644 --- a/.github/workflows/remote.yml +++ b/.github/workflows/remote.yml @@ -17,7 +17,7 @@ env: RUST_BACKTRACE: full jobs: Test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. steps: @@ -26,7 +26,7 @@ jobs: with: working-directory: remote Sanitiser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. strategy: diff --git a/.github/workflows/rt.yml b/.github/workflows/rt.yml index 3e675467..fa4c58c8 100644 --- a/.github/workflows/rt.yml +++ b/.github/workflows/rt.yml @@ -17,7 +17,7 @@ env: RUST_BACKTRACE: full jobs: Test: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. steps: @@ -26,7 +26,7 @@ jobs: with: working-directory: rt Sanitiser: - runs-on: ubuntu-latest + runs-on: ubuntu-24.04 timeout-minutes: 10 if: false # FIXME. strategy: From f05e62bf8d2b6df030078c3af0cf8943787a8f6b Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:32:29 +0100 Subject: [PATCH 2/7] Enable testing of Heph on CI --- .github/workflows/heph.yml | 7 ++++--- 1 file changed, 4 insertions(+), 3 deletions(-) diff --git a/.github/workflows/heph.yml b/.github/workflows/heph.yml index 9aceee26..30a78c1b 100644 --- a/.github/workflows/heph.yml +++ b/.github/workflows/heph.yml @@ -25,7 +25,6 @@ jobs: Test: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test @@ -34,7 +33,8 @@ jobs: Miri: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. + # TODO: enable . + if: false steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_miri @@ -43,7 +43,8 @@ jobs: Sanitiser: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. + # TODO: enable . + if: false strategy: fail-fast: false matrix: From 364f3191c04025ebb178198d79b3a033f10712b4 Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:32:39 +0100 Subject: [PATCH 3/7] Enable testing of Heph-rt on CI --- .github/workflows/rt.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/rt.yml b/.github/workflows/rt.yml index fa4c58c8..1b83e3b6 100644 --- a/.github/workflows/rt.yml +++ b/.github/workflows/rt.yml @@ -19,7 +19,6 @@ jobs: Test: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test @@ -28,7 +27,8 @@ jobs: Sanitiser: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. + # TODO: enable . + if: false strategy: fail-fast: false matrix: From 50f7763b4acf2552aa038c552ae70b588715230d Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:32:51 +0100 Subject: [PATCH 4/7] Enable testing of Heph-remote on CI --- .github/workflows/remote.yml | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/.github/workflows/remote.yml b/.github/workflows/remote.yml index ac12c8b0..52912e76 100644 --- a/.github/workflows/remote.yml +++ b/.github/workflows/remote.yml @@ -19,16 +19,16 @@ jobs: Test: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. steps: - uses: actions/checkout@v4 + - name: Install Cargo-hack + run: cargo install --debug cargo-hack - uses: ./.github/workflows/test with: working-directory: remote Sanitiser: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. strategy: fail-fast: false matrix: From a053549d3a1c2857be66127f6de30aaf18b4c4d3 Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:34:30 +0100 Subject: [PATCH 5/7] Link issues to Heph-HTTP CI --- .github/workflows/http.yml | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/.github/workflows/http.yml b/.github/workflows/http.yml index 7f957eac..7cee7978 100644 --- a/.github/workflows/http.yml +++ b/.github/workflows/http.yml @@ -19,7 +19,8 @@ jobs: Test: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. + # TODO: enable . + if: false steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test @@ -28,7 +29,8 @@ jobs: Sanitiser: runs-on: ubuntu-24.04 timeout-minutes: 10 - if: false # FIXME. + # TODO: enable . + if: false strategy: fail-fast: false matrix: From a5c7b7d0f74ac665ea0e787b9be0f43b40ac2622 Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:39:09 +0100 Subject: [PATCH 6/7] Skip LeakSanitizer It's broken, see https://github.com/rust-lang/rust/issues/111073. --- Makefile.include | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/Makefile.include b/Makefile.include index e62231ff..8afd53f6 100644 --- a/Makefile.include +++ b/Makefile.include @@ -26,7 +26,9 @@ test: test_sanitizers: $(MAKE) test_sanitizer sanitizer=address - $(MAKE) test_sanitizer sanitizer=leak + # LeakSanitizer is broken, see + # . + #$(MAKE) test_sanitizer sanitizer=leak $(MAKE) test_sanitizer sanitizer=memory $(MAKE) test_sanitizer sanitizer=thread From 570855f8fa4b9b181bc8c780d66d153e8a5582c0 Mon Sep 17 00:00:00 2001 From: Thomas de Zeeuw Date: Sun, 22 Dec 2024 12:49:31 +0100 Subject: [PATCH 7/7] Disable LeakSanitizer in CI It's broken, see https://github.com/rust-lang/rust/issues/111073. --- .github/workflows/heph.yml | 4 +++- .github/workflows/http.yml | 4 +++- .github/workflows/inbox.yml | 4 +++- .github/workflows/remote.yml | 4 +++- .github/workflows/rt.yml | 4 +++- 5 files changed, 15 insertions(+), 5 deletions(-) diff --git a/.github/workflows/heph.yml b/.github/workflows/heph.yml index 30a78c1b..9b0ec29f 100644 --- a/.github/workflows/heph.yml +++ b/.github/workflows/heph.yml @@ -48,7 +48,9 @@ jobs: strategy: fail-fast: false matrix: - sanitiser: [address, leak, memory, thread] + # LeakSanitizer is broken, see + # . + sanitiser: [address, memory, thread] # leak steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_sanitizer diff --git a/.github/workflows/http.yml b/.github/workflows/http.yml index 7cee7978..1c44b631 100644 --- a/.github/workflows/http.yml +++ b/.github/workflows/http.yml @@ -34,7 +34,9 @@ jobs: strategy: fail-fast: false matrix: - sanitiser: [address, leak, memory, thread] + # LeakSanitizer is broken, see + # . + sanitiser: [address, memory, thread] # leak steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_sanitizer diff --git a/.github/workflows/inbox.yml b/.github/workflows/inbox.yml index 8d8d4b36..faccd325 100644 --- a/.github/workflows/inbox.yml +++ b/.github/workflows/inbox.yml @@ -45,7 +45,9 @@ jobs: strategy: fail-fast: false matrix: - sanitiser: [address, leak, memory, thread] + # LeakSanitizer is broken, see + # . + sanitiser: [address, memory, thread] # leak steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_sanitizer diff --git a/.github/workflows/remote.yml b/.github/workflows/remote.yml index 52912e76..101466ee 100644 --- a/.github/workflows/remote.yml +++ b/.github/workflows/remote.yml @@ -32,7 +32,9 @@ jobs: strategy: fail-fast: false matrix: - sanitiser: [address, leak, memory, thread] + # LeakSanitizer is broken, see + # . + sanitiser: [address, memory, thread] # leak steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_sanitizer diff --git a/.github/workflows/rt.yml b/.github/workflows/rt.yml index 1b83e3b6..3fce043d 100644 --- a/.github/workflows/rt.yml +++ b/.github/workflows/rt.yml @@ -32,7 +32,9 @@ jobs: strategy: fail-fast: false matrix: - sanitiser: [address, leak, memory, thread] + # LeakSanitizer is broken, see + # . + sanitiser: [address, memory, thread] # leak steps: - uses: actions/checkout@v4 - uses: ./.github/workflows/test_sanitizer