Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Changes #4

Open
wassereimer86 opened this issue Jan 1, 2021 · 0 comments
Open

Changes #4

wassereimer86 opened this issue Jan 1, 2021 · 0 comments

Comments

@wassereimer86
Copy link

wassereimer86 commented Jan 1, 2021

Hi,

i´ve made two minor changes for the Website https://seife.lavendelhexe.net/. I want to place them here so you can think about implementing them. They are not perfectly, need some work and also other things should be removed and changed but you will get the point. Also i dign´t want to make a pull request because of that.

I moved
<?php mercia_header_image(); ?>
under
<div id="page" class="hfeed site">
and changed the function to

if ( ! function_exists( 'mercia_header_image' ) ) :
	/**
	 * Displays the custom header image below the navigation menu
	 */
	function mercia_header_image() {

		if ( has_header_image() ) : ?>
			<a href="<?php echo esc_url( home_url( '/' ) ); ?>">
				<img src="<?php header_image(); ?>" srcset="<?php echo esc_attr( wp_get_attachment_image_srcset( get_custom_header()->attachment_id, 'full' ) ); ?>" width="<?php echo esc_attr( get_custom_header()->width ); ?>" height="<?php echo esc_attr( get_custom_header()->height ); ?>" alt="<?php echo esc_attr( get_bloginfo( 'name', 'display' ) ); ?>">
			</a>
		<?php
		endif;
	}
endif;

The Header Image was way too big and didn´t look good from my opinion. Now its in the site area. I also made css changes so that it looks good.

@media only screen and (min-width: 75em)
.header-main {
    padding: 1em 0 2em 0 !important;
}
.header-main {
    padding: 1em 0 1.5em 0 !important;
}
@media only screen and (min-width: 75em)
.site {
    padding: 2.5em 2.5em 0 2.5em !important;
}
@media only screen and (min-width: 40em)
.site {
    padding: 2em 2em 0 2em !important;
}
.site {
    padding: 1.5em 1.5em 0 1.5em !important;
}

Than i added an comment counter to the meta tags. It should be linked to the comments section from the post - but i haven´t done this yes. So i changed this

if ( ! function_exists( 'mercia_entry_meta' ) ) :
	/**
	 * Displays the date, author and categories of a post
	 */
	function mercia_entry_meta() {

		$postmeta = mercia_meta_date();
		$postmeta .= mercia_meta_author();
		$postmeta .= mercia_meta_comment();
		$postmeta .= mercia_meta_category();

		echo '<div class="entry-meta">' . $postmeta . '</div>';
	}
endif;

and added this

if ( ! function_exists( 'mercia_meta_comment' ) ) :
	/**
	 * Displays the post comment count
	 */
	function mercia_meta_comment() {

		$comment_string = get_comments_number_text();

		$posted_comment = mercia_get_svg( 'comment' ) . $comment_string;

		return '<span class="meta-author"> ' . $posted_comment . '</span>';
	}
endif;

Thank you for the Theme.

Best Regards
Jens

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant