Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Claim gateways on The Things Gateway Controller #7201

Merged
merged 4 commits into from
Aug 1, 2024

Conversation

johanstokking
Copy link
Member

Summary

References https://github.com/TheThingsIndustries/lorawan-stack/issues/4256
Follow up on #7198 and https://github.com/TheThingsIndustries/lorawan-stack/issues/4301

Changes

This implements The Things Gateway Controller upstream for gateway claiming.

Testing

Steps

...

Results
Regressions

...

Notes for Reviewers

This is draft until testing is done and testing steps are filled out. The code can already be reviewed.

The unit tests are quite sparse because it's a light API wrapper for The Things Gateway Controller. I don't think it makes a lot of sense to stub te server as there isn't a lot of logic that needs testing or protection against regressions. I'm also fine adding server stubs though.

Checklist

  • Scope: The referenced issue is addressed, there are no unrelated changes.
  • Compatibility: The changes are backwards compatible with existing API, storage, configuration and CLI, according to the compatibility commitments in README.md for the chosen target branch.
  • Documentation: Relevant documentation is added or updated.
  • Testing: The steps/process to test this feature are clearly explained including testing for regressions.
  • Infrastructure: If infrastructural changes (e.g., new RPC, configuration) are needed, a separate issue is created in the infrastructural repositories.
  • Changelog: Significant features, behavior changes, deprecations and fixes are added to CHANGELOG.md.
  • Commits: Commit messages follow guidelines in CONTRIBUTING.md, there are no fixup commits left.

@johanstokking johanstokking added this to the v3.32.0 milestone Jul 29, 2024
@johanstokking johanstokking self-assigned this Jul 29, 2024
@github-actions github-actions bot added c/identity server This is related to the Identity Server c/gateway server This is related to the Gateway Server compat/db This could affect Database compatibility c/gateway conf server This is related to the Gateway Configuration Server dependencies Pull requests that update a dependency file ui/web This is related to a web interface tooling Development tooling compat/config This could affect Configuration compatibility labels Jul 29, 2024
@johanstokking johanstokking changed the base branch from v3.31 to feature/tti-gtw-lorapf July 29, 2024 21:09
@johanstokking johanstokking force-pushed the feature/ttgc-claiming branch 2 times, most recently from 1de3829 to 7a4b254 Compare July 31, 2024 13:34
@johanstokking johanstokking force-pushed the feature/ttgc-claiming branch from 7a4b254 to 5974120 Compare July 31, 2024 19:47
@johanstokking johanstokking marked this pull request as ready for review July 31, 2024 20:18
@johanstokking johanstokking requested review from a team as code owners July 31, 2024 20:18
@johanstokking johanstokking requested review from KrishnaIyer and removed request for a team July 31, 2024 20:18
Base automatically changed from feature/tti-gtw-lorapf to v3.32 July 31, 2024 20:20
Copy link
Member

@KrishnaIyer KrishnaIyer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@johanstokking johanstokking merged commit 15ddbd9 into v3.32 Aug 1, 2024
15 checks passed
@johanstokking johanstokking deleted the feature/ttgc-claiming branch August 1, 2024 09:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
c/gateway conf server This is related to the Gateway Configuration Server c/gateway server This is related to the Gateway Server c/identity server This is related to the Identity Server compat/config This could affect Configuration compatibility compat/db This could affect Database compatibility dependencies Pull requests that update a dependency file tooling Development tooling ui/web This is related to a web interface
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants