-
Notifications
You must be signed in to change notification settings - Fork 316
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Claim gateways on The Things Gateway Controller #7201
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
johanstokking
commented
Jul 29, 2024
1de3829
to
7a4b254
Compare
7a4b254
to
5974120
Compare
KrishnaIyer
approved these changes
Aug 1, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
c/gateway conf server
This is related to the Gateway Configuration Server
c/gateway server
This is related to the Gateway Server
c/identity server
This is related to the Identity Server
compat/config
This could affect Configuration compatibility
compat/db
This could affect Database compatibility
dependencies
Pull requests that update a dependency file
tooling
Development tooling
ui/web
This is related to a web interface
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
References https://github.com/TheThingsIndustries/lorawan-stack/issues/4256
Follow up on #7198 and https://github.com/TheThingsIndustries/lorawan-stack/issues/4301
Changes
This implements The Things Gateway Controller upstream for gateway claiming.
Testing
Steps
...
Results
Regressions
...
Notes for Reviewers
This is draft until testing is done and testing steps are filled out. The code can already be reviewed.
The unit tests are quite sparse because it's a light API wrapper for The Things Gateway Controller. I don't think it makes a lot of sense to stub te server as there isn't a lot of logic that needs testing or protection against regressions. I'm also fine adding server stubs though.
Checklist
README.md
for the chosen target branch.CHANGELOG.md
.CONTRIBUTING.md
, there are no fixup commits left.